GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/653
TS-4331Major re-write of hostdb
This is still a WIP, but I figure it's about time to get some feedback on
the code here.
The primary goal of this is to fix the crashing issues described in
TS-4331, where basically multicache wasn't keeping track of who referenced
various items within the cache.
At this point my TODO list still is:
- Configurable size/item limits
- configurable max RR/SRV records (instead of a constant)
- Additional tests
-- tests for syncing/loading cache from disk
- cleanup alloc() method in RefCountCache (now its using new, need to
either move to ClassAllocator or to just pad the iobuf allocation and put them
in there)
- bounds checking in alloc() (specifically that we could even allocate an
item of the size requested)
- additional metrics
-- number of items
-- total size
-- hit rate
I'm sure more will come up, I'll do my best to keep this list ^^ up-to-date
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver hostdb_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #653
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
