Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/657#discussion_r64239248
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -241,17 +243,22 @@ Http2Stream::do_io_close(int /* flags */)
{
current_reader = NULL; // SM on the way out
if (!sent_delete) {
+ SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
--- End diff --
The reenable is concerning. Agreed. That should happen very rarely, but
would be a bear when it happens. I was mostly concerned with holding the lock
while doing state changes to the Stream object (changing closed, sent_delete
and parent). I'll restructure to drop the lock before going into reenable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
