Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/686#discussion_r65657843
--- Diff: mgmt/api/INKMgmtAPI.cc ---
@@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id)
tsapi TSMgmtError
TSEncryptPassword(char *passwd, char **e_passwd)
--- End diff --
No we don't need to do API review for the management API, only for plugin
APIs.
> On Jun 2, 2016, at 9:37 AM, Masaori Koshiba <[email protected]>
wrote:
>
> In mgmt/api/INKMgmtAPI.cc:
>
> > @@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id)
> > tsapi TSMgmtError
> > TSEncryptPassword(char *passwd, char **e_passwd)
> I agree with that. Do we need API review to remove? This looks like one
of TS API.
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
