GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/704
TS-4531: Clarify time unit confusion in HostDB sync interval.
Commit d48b76e tried to fix some of the time unit conversions in
HostBD, but didn't notice that RefCountedHostsFileMap::next_sync_time
was getting initialized to a nanosecond timestamp + an interval in
seconds.
This clarifies most of the timestamps uses in hosts file update
checking, which are all in Unix epoch seconds. We remove the
HOST_DB_TIMEOUT_INTERVAL definition since that interval is not
really a changeable (all the code assumes it is 1 sec).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4531
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/704.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #704
----
commit affe97bbd37d9194f4057860ef632a4644c79892
Author: James Peach <[email protected]>
Date: 2016-06-13T21:25:40Z
TS-4531: Clarify time unit confusion in HostDB sync interval.
Commit d48b76e tried to fix some of the time unit conversions in
HostBD, but didn't notice that RefCountedHostsFileMap::next_sync_time
was getting initialized to a nanosecond timestamp + an interval in
seconds.
This clarifies most of the timestamps uses in hosts file update
checking, which are all in Unix epoch seconds. We remove the
HOST_DB_TIMEOUT_INTERVAL definition since that interval is not
really a changeable (all the code assumes it is 1 sec).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
