Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r68482139
--- Diff: proxy/http/HttpTransact.h ---
@@ -905,8 +905,9 @@ class HttpTransact
int next_hop_scheme; // out
int orig_scheme; // pre-mapped scheme
int method;
- int cause_of_death_errno; // in
- HostDBInfo host_db_info; // in
+ int cause_of_death_errno; // in
+ Ptr<HostDBInfo> hostdb_entry; // Pointer to the entry we are
referencing in hostdb-- to keep our ref
--- End diff --
Although `host_db_info` is a copy-- none of the related structures are
(meaning things that are offsets like rr() etc. aren't copied over. IMO we
should probably change this to pointer anyways-- so we can still point directly
to the hostdbinfo we want-- without having to do the copy (since it isn't
sufficient anyways).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
