+1 On Thu, Mar 4, 2021 at 4:22 PM Robert O Butts <robert.o.bu...@gmail.com> wrote:
> > > void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction > action); - > > I still don't like passing the action by value. > > Yes, it's a pointer now. Sorry, I changed the code, forgot to update the PR > description: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_trafficserver_blob_f22e1c_src_traffic-5Fserver_InkAPI.cc-23L10039&d=DwIBaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=5nE_8e-Jc1t5vF6GVeub9BCN4FzSc_6kU7_mjSiUrDs&m=zFZbls36NrhIT2vj_0hfqinSa9lAhT-6H4trx4FBBoQ&s=fB-M3Z_KFA6aSyaHeYdEIPIMyITM1nAhfCfnCwf7pO4&e= > > void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction *action); > > > On Thu, Mar 4, 2021 at 3:18 PM Alan Carroll > <solidwallofc...@verizonmedia.com.invalid> wrote: > > > > > > > I think you noted that TSHostnameIsSelf(const char *hostname) is > painful > > > to make take a non-null terminated string. Is that still the case? > > > > > > void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction > action); - > > I still don't like passing the action by value. > > >
