Hey all, I think we already decided that in the vote thread on contribution guidelines [1].
Reading it again I've phrased it less than totally clear, but it is implicitly stated that one review is enough in most cases. I'll make sure to phrase that clearer in the actual guidelines. Best regards, Sönke [1] https://lists.apache.org/thread.html/467cd2008f8045e1d1db87ed541e060ba1989d9c52024f2d011fb91a@%3Cdev.training.apache.org%3E On Sun, Apr 28, 2019 at 12:00 PM Lars Francke <[email protected]> wrote: > That's for us to define. > > I like the model of requiring a single +1 from someone other than the > contributor itself. That's what most Apache projects I'm involved with use. > > Using that model what you did looks fine to me. Either way we're still > getting started and I'm fine with having no strict rules for the first few > weeks to get all the boilerplate/infrastructure set up. > > I believe Sönke wanted to write a contributors guide. He's opened a new > Jira for it. That would be a good place to discuss this. > > On Sat, Apr 27, 2019, 10:18 Justin Mclean <[email protected]> wrote: > > > Hi, > > > > Most other apache communities Im involved with are CTR rather than RTC so > > no idea what the norm is. > > > > Thanks, > > Justin > -- Sönke Liebau Partner Tel. +49 179 7940878 OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
