Hi, I just added a review on Github and had a couple of comments which you mostly addressed here so I'll continue the conversation here. As we didn't have a review for Chris' stuff this is mostly not about what you added Justin but about the template itself.
On Sat, Apr 27, 2019 at 9:01 AM Justin Mclean <[email protected]> wrote: > Hi, > > So using Chris template I converted a set of my own slides and submitted a > PR with it. > > Some notes: > - Make sure you spell asciidoc directory correctly otherwise it will > compile but produce nothing :-) > - To have a slide with no title use “## !”. > - To have hard new lines use + at the end of line. > - Dark themes are good for screen but generally look poor on projectors, > modified the css to be black text on white and use a more common fonts with > fallbacks. > It'd be great if we could have the CSS in some "common" directory so not everything repeats the basic stuff. > > Al in all it was fairly easy to convert but there is a couple of rough > corners. > - Work out how to crop images and video so it the same as in the original > presentation. > - Footer is not showing for some unknown reason. > - Move titles to top of page rather than entering comment. > - Annoying to have to rename index.revealjs to index.html all the time. > Yes, this is super annoying! Also...it creates a WAR file? There's also commented out stuff in the pom etc. The install-deps.sh is for MacOS only and has no documentation, is it really needed? What for? > Questions: > - While there's no branding (other than the ASF) it does have my name on > it and a slide or two assumes I’m the person given it. Do we want to make > it more anonymous? > I'm in favor of making it anonymous, yes. A similar reason to the @author tags. This information is prone to go stale as more people contribute to it. > - Have I put it in the right place? > - What can we do to cut down on duplication? There's a few files I copies > and duplicated from Chris’s example. > - It builds on it own but not as part of the whole repo. Do we want to do > that? > Well, this is my vision and nothing more: Yes, it's in the right place, mostly. But it shouldn't contain the pom.xml and reveal stuff (template, css). In my mind we'd have a "content" repository in the "content" folder (including asciidoc, jpg, mp4 files etc.) and then assemble that with yet to be designed tools (or shell scripts) in the "sessions" folder which would hopefully allow us to reuse css and other things. > > Thanks, > Justin
