Hi, I suggest only submitting pr to IoTDB, and once we make sure the code is finally ok, then migrate the code again.
Jialin Qiao Yuan Tian <[email protected]> 于2024年1月4日周四 18:58写道： > > Hi all, > > I'm trying to remove the jol dependency, and I wonder that which repo > should I submit that pr to? TsFile or IoTDB? or both? > > On Thu, Jan 4, 2024 at 9:12 AM Yuan Tian <[email protected]> wrote: > > > Hi Chris, > > > > Thanks for the reminder. We will try to find some other lib with approved > > licenses to replace that. > > > > > > Best regards, > > ----------------------------- > > Yuan Tian > > > > On Wed, Jan 3, 2024 at 9:50 PM Christofer Dutz <[email protected]> > > wrote: > > > >> Hi all, > >> > >> while doing the TsFile split and going through the dependencies, I > >> stumbled over one dependency in the commons-api module: > >> > >> <dependency> > >> <groupId>org.openjdk.jol</groupId> > >> <artifactId>jol-core</artifactId> > >> </dependency> > >> > >> Which actually is the only dependency of that module. But the “opendjk” > >> got me thinking: Isn’t everything with OpenJDK GPL licensed? And indeed. > >> This library is licensed by the GPL2 license + class path exception. > >> > >> We are not allowed to have this type of dependencies in our project, as > >> it’s category X rated: > >> https://www.apache.org/legal/resolved.html > >> > >> There it states clearly: > >> > >> * GNU GPL 1, 2, 3<http://www.opensource.org/licenses/gpl-license.php> > >> * Special exceptions to the GNU GPL (e.g. GNU Classpath) unless > >> otherwise permitted elsewhere on this page. > >> And the only mention on that page is JavaDoc. > >> > >> So, I think we should remove that dependency as quickly as possible. In > >> both IoTDB and TsFile. > >> > >> Chris > >> > >>
