Thanks you a lot. Actually, there was another reason for the modifications I made at that time: I wanted the results from the 'mvn' build to be consistent with the build results from scripts on different systems, so they would not need to perform an additional build using MVN.
I think that it is feasible to use MVN to manage the complete build of a project with TSFILE, but it requires some technical knowledge of MVN. I will also provide some compilation tools in the C++ directory for different architectures. Colin. At 2024-06-12 23:14:53, "Christofer Dutz" <[email protected]> wrote: >Actually, there should not really be many alterations needed in the pom file. >All alterations should be done in the CMakeLists.txt files … all the plugin >does is download the right version of cmake and run that. >I am currently investigating the compilations issues I am seeing after going >back to cmake-maven-pluign. >I think we’ll have to make the code a bit mode platform-aware. So I guess >we’ll probably have to do some checks in cmake and set some defines that then >trigger different ifdef blocks. >For example, the execinfo.h seems to be problematic on windows system, so >probably conditional compilation is required in order to support that. > >Currently managed to get to 88% of the compilation … trying to sort out some >oddities with “pread” on windows. Whill submit a PR once I’ve managed to get >things working. > >Theoretically a C/C++ developer should probably not need to even use Maven … >however getting the universal build working on all platforms is going to be >more a C/C++ problem than a Maven problem. > >Chris > > >Von: Colin_Lee <[email protected]> >Datum: Mittwoch, 12. Juni 2024 um 16:32 >An: [email protected] <[email protected]> >Betreff: Re:AW: Re:AW: Re:Re: No support for C++ lib in windows environment >The main reasons for my modifications are as follows: > >C/C++ developers might not be aware of how to alter compilation options in the >POM file, or how to add or modify compilation configurations or dependencies. >Using scripts for compilation allows for convenient modifications. >Code style checks are not supported in Maven (although it has been proven >possible to enforce this as a documentation constraint), nor are they >implementable through scripts. >Maven does not support code testing with Google Test (some of the current unit >tests are written with GoogleTest and have not yet been merged). > >As a result, I have transformed the build and test methods in the POM file to >execute scripts, which are intuitive but have caused compatibility issues. >There are still some code adjustments needed in the current compilation tool, >and it is not perfect at present. > >Regarding dependencies in the code, C++ does not rely on any other >dependencies or third-party libraries. > > >At 2024-06-12 22:10:19, "Christofer Dutz" <[email protected]> wrote: >>So, if I go to the state of the PR where I updated the Cmake Plugin version >>to the latest versions I got the build working for all systems. >>So, there must have been some changes since then that are causing problems. >>If I leave the generator at mingw, I seem to be missing some glibc header >>files. >>If I update it to Visual Studio 2017 (Like the IoTDB build) I get errors from >>the MSBuild executable complaining about problems in the vcxproj files. >> >>I’ll take a deeper look … I assume what happened, was that you were working >>on the code using your C/C++ IDE and added dependencies that the maven+cmake >>build doesn’t know about. >>In this case I guess we should work together on this to get it working again. >> >>Chris >> >> >>Von: Christofer Dutz <[email protected]> >>Datum: Mittwoch, 12. Juni 2024 um 15:53 >>An: [email protected] <[email protected]> >>Betreff: AW: Re:AW: Re:Re: No support for C++ lib in windows environment >>Hi, >> >>So, I think now I know what’s going on … I had finished supporting TsFile on >>all types (Win, Lnx, Mac) for both x86 as well as aarch64. >>However last week you replaced the build to no longer use the >>cmake-maven-plugin, but the exec-maven-plugin. >> >>May I ask why? >> >>This version now definitely is no longer portable to other OSes. >> >>Chris >> >> >> >> >>Von: Christofer Dutz <[email protected]> >>Datum: Mittwoch, 12. Juni 2024 um 15:39 >>An: [email protected] <[email protected]> >>Betreff: AW: Re:AW: Re:Re: No support for C++ lib in windows environment >>In general, you should be able to simply run the build on Windows … given the >>MinGW toolchain is available, it should build without issues. >>However, I’ll give it a try and double check … >> >>Chris >> >>Von: Colin_Lee <[email protected]> >>Datum: Mittwoch, 12. Juni 2024 um 13:09 >>An: [email protected] <[email protected]> >>Betreff: Re:AW: Re:Re: No support for C++ lib in windows environment >>Hi Chris, >> >>Thank you for your reply. There seems to be a misunderstanding; C++ has not >>yet been supported for compilation on Windows, as the project has not >>continued to adapt for the time being. The issue encountered is related to >>the installation permissions of Cython for Python TsFile on GitHub CI. >> >>The compilation chain in TsFile's current code is adapted to the GNU >>compilation environment on Linux, and the MinGW compilation chain is quite >>similar to this. >> >>My development environment is Linux, and I have limited experience in >>developing C++ programs on Windows. I think that being compatible with both >>should not be a burden, as our code does not use Boost, so it might just be a >>difference in the compilation script. I can try to support both compilation >>chains. >> >>Best regrads, >> >>Colin >> >> >> >> >> >> >> >> >>At 2024-06-12 17:45:57, "Christofer Dutz" <[email protected]> wrote: >>>Hi Colin, >>> >>>I just had a look and I had already updated the build-chain to the latest >>>version of CMake. >>>May I ask which issues you are having? >>> >>>I do see that we’re using the MinGW build tool-chain in TsFile … in IoTDB >>>we’re using the Visual Studio one, as Boost was not compatible with this. >>> >>>Would you all prefer using the VisualStudio build tool chain? >>> >>>Should be a quick change. >>> >>>Chris >>> >>> >>> >>>Von: Colin_Lee <[email protected]> >>>Datum: Freitag, 7. Juni 2024 um 09:17 >>>An: [email protected] <[email protected]> >>>Betreff: Re:Re: No support for C++ lib in windows environment >>>Thank you very much. >>> >>>I have written a Cython project to help users read tsfiles or write pandas >>>DataFrames into tsfiles within a Python environment. >>> >>>To build Cython on CI, I need to install some third-party packages, such as >>>Cython and NumPy. >>> >>>I tried to install Python packages using pip3 in GitHub's workflow >>>unit-test.yml, but I encountered permission issues on macos-latest. >>> >>>I add --user to `pip3 install` cmd but it not work. >>> >>>What should I modify? Thanks you again. >>> >>> >>> >>> >>>Best regards >>> >>>Colin. >>> >>> >>> >>> >>> >>> >>> >>>The link is >>>https://github.com/apache/tsfile/actions/runs/9312534947/job/25633479617 >>> >>>Error message: >>> >>>``` >>> >>>[INFO] --- exec:1.6.0:exec (install-python-dependencies) @ tsfile-python --- >>> >>>error: externally-managed-environment >>> >>> >>> >>> >>>× This environment is externally managed >>> >>>╰─> To install Python packages system-wide, try brew install >>> >>> xyz, where xyz is the package you are trying to >>> >>> install. >>> >>>``` >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>>At 2024-06-07 03:09:53, "Christofer Dutz" <[email protected]> wrote: >>>>I've just recently helped get cmake working on windows... Will update >>>>things as soon as I'm home from Bratislava. >>>> >>>>Chris >>>> >>>>Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> >>>>________________________________ >>>>From: Yuan Tian <[email protected]> >>>>Sent: Thursday, June 6, 2024 9:42:29 AM >>>>To: [email protected] <[email protected]> >>>>Subject: Re: No support for C++ lib in windows environment >>>> >>>>ok, Colin, feel free to ask in mail list about the Windows compilation >>>>chain if you have any problems. I think Chris is expert in that and can do >>>>some help for you. >>>> >>>> >>>>Best regards, >>>>--------------------- >>>>Yuan Tian >>>> >>>>On Thu, Jun 6, 2024 at 3:16 PM Colin_Lee <[email protected]> wrote: >>>> >>>>> Hi Tian, >>>>> >>>>> Thank you for your attention. >>>>> >>>>> TsFile C++ currently does not support the Windows compilation chain, but >>>>> it is working on Linux and MacOS. >>>>> >>>>> And support for C++ compilation on Windows will be added later. >>>>> >>>>> >>>>> >>>>> >>>>> Best regards, >>>>> >>>>> Colin >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> At 2024-06-06 15:07:01, "Yuan Tian" <[email protected]> wrote: >>>>> >Hi all, >>>>> > >>>>> >I just found that we don't support C++ in the Windows environment, is >>>>> there >>>>> >any reason for this? >>>>> > >>>>> >Best regards, >>>>> >------------------------ >>>>> >Yuan Tian >>>>> >>>
