-1 PMC cdutz (binding)
Chris
[OK] Download all staged artifacts under the url specified in the release vote
email.
[OK] Verify the signature is correct.
[MINOR] Check if the signature references an Apache email address.
* The key is not part of any ring of trust with core Apache folks, the
community should think about joining Key-Signing-Parties during community over
code events
[OK] Verify the SHA512 hashes.
[OK] Unzip the archive.
[OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in
the extracted source bundle.
[MAJOR] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in
the
extracted source bundle.
* LICENSE
* The part of the takari maven wrapper is a bit mis-leading (We might
simply remove that code, re-generate if via the new maven tooling and then
remove this section of the LICENSE file.
* The section about the Murmur128Hash.java doesn’t have the right path
listed. It should be:
ava/tsfile/src/main/java/org/apache/tsfile/utils/Murmur128Hash.java
* Same applies to the section about the gorilla stuff … here the paths
listed in the LICENSE file don’t match their actual path:
java/tsfile/src/main/java/org/apache/tsfile/encoding/encoder/GorillaEncoderV2.java
* The files listed in the Gorilla section all have the normal Apache
headers, however I doubt that they were actually “Licensed to the ASF” but only
“with the Apache license”.
* The section about the chimp files also has wrong paths
* The files taken from the chimp project also all seem to have the
default Apache headers on them, however in the original project no headers are
being used .. I don’t think it’s ok to simply stick an Apache header to the
files and use the version that states that things were licensed TO the Apache
Software Foundation (Please see the bottom part of this:
https://www.apache.org/licenses/LICENSE-2.0)
* For both the Gorilla as well as the Chimp parts it’s hard to see where
they came from (possibly link a revision) as the repos have both significantly
changed.
[MINOR] Run RAT externally to ensure there are no surprises.
* The following files need apache headers:
* apache-tsfile-1.1.0/cpp/cmake/build_function.cmake
* apache-tsfile-1.1.0/cpp/cmake/config.h.in
* apache-tsfile-1.1.0/docs/src/.vuepress/public/bg.svg
* apache-tsfile-1.1.0/docs/src/.vuepress/public/home_icon.svg
* apache-tsfile-1.1.0/docs/src/.vuepress/public/logo.svg
* apache-tsfile-1.1.0/docs/src/.vuepress/public/s.svg
* apache-tsfile-1.1.0/docs/src/.vuepress/styles/config.scss
* apache-tsfile-1.1.0/docs/src/.vuepress/styles/index.scss
* apache-tsfile-1.1.0/docs/src/.vuepress/styles/palette.scss
[OK] Search for SNAPSHOT references
[MAJOR] Search for Copyright references, and if they are in headers, make sure
these files containing them are mentioned in the LICENSE file.
* Cpp/src/compress/lz4.c/h contain copied code from
https://github.com/lz4/lz4 which is not listed in the LICENSE file.
[OK] Build the project according to the information in the README.md file.
Considering the large number of files that most probably have the wrong header,
I would suggest we go for an RC2 and address all of the above.
Von: Haonan Hou <[email protected]>
Datum: Freitag, 1. November 2024 um 11:10
An: [email protected] <[email protected]>
Betreff: [VOTE] Apache TsFile 1.1.0 RC1 release
Hi all,
Apache TsFile 1.1.0 has been staged under [2] and it’s time to vote
on accepting it for release. All Maven artifacts are available under [1].
Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Release tag: v1.1.0
Hash for the release tag: af7eec03ce5eccac624b3cfe17cc543f0f1c7b06
Before voting +1, PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases. [3]
[ ] +1 accept (indicate what you validated)
[ ] -1 reject (explanation required)
[1] https://repository.apache.org/content/repositories/orgapachetsfile-1003
[2] https://dist.apache.org/repos/dist/dev/tsfile/1.1.0/rc1
[3] https://www.apache.org/dev/release.html#approving-a-release
[4] https://dist.apache.org/repos/dist/dev/tsfile/1.1.0/rc1/RELEASE_NOTES.md
[5] https://dist.apache.org/repos/dist/dev/tsfile/KEYS
Best,
Haonan Hou
