I don't see any problem removing the methods that return ConcreteElement. If
we look at screens we see that VelocityScreen and BaseJspScreen implements
these methods, but any subclasses to them that are created in projects using
Turbine probably do not ovverride these.
There is another issue with the methods in the modules:
Since the doBuild(RunData ....) is left in the modules but the actual ones
used is doBuild(PipelineData...), developers that upgrade from Turbine 2.3.3
to Turbine 4 will not get any errors at compile time, bur the behaviour of
the code will change and it can be har to trace. This was the sutiation for
me.
However, if java5+ is used with the @Override annotation at the
doBuildTemplate methods users will realize that they need to change from
RunData to PipelineData
My point is: The modules will go through big changes anyway, better to do
this as well now than to save it.
/Ludwig
-----Ursprungligt meddelande-----
From: Thomas Vandahl
Sent: Thursday, November 10, 2011 11:06 PM
To: Turbine Developers List
Subject: [DISCUSS] Getting rid of ECS?
Hi folks,
I was trying to pull some stuff straight in the RunData/PipelineData
when I stumbled across different types of ECS references that are not
really required for Turbine to function. Like RunData.addMessage() and
friends and the Document handling in DefaultTurbineRunData. Most of the
modules use ECS as well.
BaseJspNavigation.java
BaseJspScreen.java
DateSelector.java
DefaultPage.java
DefaultTurbineRunData.java
Error.java
InputFilterUtils.java
InvalidState.java
Navigation.java
NavigationLoader.java
RawScreen.java
RunData.java
Screen.java
ScreenLoader.java
SelectorBox.java
TemplateNavigation.java
TemplateNavigation.java
TemplateScreen.java
TemplateScreen.java
TimeSelector.java
VelocityDirectScreen.java
VelocityNavigation.java
VelocityOnlyLayout.java
VelocityScreen.java
VelocityXslLayout.java
Do we want to remove these references? It should not affect a generic
Turbine application much. The API of Screens, Navigations and Layouts
would however change incompatibly. What is your opinion on this?
Bye, Thomas.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
