On 11.11.11 09:16, Ludwig Magnusson wrote: > This change is not that easy to me. > Our application retreives acl, parameters, request, response, message, > locale, screentemplates ect all over the place. > > This change would be too big and I'm having a hard time seeing the > benefits.
I'm afraid there is some misunderstanding here. I was talking about the *setters*, not getters. So RunData.getParameters() would still be in place, only TurbineRunData.setParameters() would be removed. > In any case, the PipelineData do* methods need to be reconsidered IMO. > The access to important data is much more complicated than with RunData > and I see actually no real reason for a reduced interface. Let me add some details on this. Obviously, there is an initial need for the PipelineData object in the Pipeline itself and the Valves in use. The question is - given the simplistic interface of PipelineData - what we gain from this typed object. Wouldn't RunData just do the trick as well? We would save people from changing each and every module and the constant casting that would be going on. The whole processing would be much smoother. What would that mean? - Replace PielineData with RunData in TurbinePipeline and the Valves - Remove the doWhatever(PipelineData, ...) methods from the modules. - Clean up the other references afterwards. Hope I made myself clear. Bye, Thomas. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
