Hi folks,

had a quick look (long train ride without internet)

[ ] -1 no, do not release it because - one test fails for me when running Maven 
and IntelliJ

Failed tests: 
  
JacksonMapperEnabledDefaultTyping_OBJECT_AND_NON_CONCRETE_Test.testDeSerializeDate:110

Tests run: 88, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Fulcrum JSON Master Build .......................... SUCCESS [  2.341 s]
[INFO] Fulcrum JSON API ................................... SUCCESS [  2.572 s]
[INFO] Fulcrum JSON GSON Impl ............................. SUCCESS [  3.002 s]
[INFO] Fulcrum JSON Jackson Impl .......................... SUCCESS [  2.535 s]
[INFO] Fulcrum JSON Jackson 2.x Impl ...................... FAILURE [ 11.212 s]
[INFO] Fulcrum JSON Jar Distribution ...................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.833 s
[INFO] Finished at: 2017-07-16T23:14:33+02:00
[INFO] Final Memory: 28M/518M
[INFO] ------------------------------------------------------------------------

fulcrum-json-1.1.1> java -version
java version "1.8.0_121"
Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)

fulcrum-json-1.1.1> mvn -v
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 
2014-08-11T22:58:10+02:00)
Maven home: /usr/local/Cellar/maven/3.2.3/libexec
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: utf-8
OS name: "mac os x", version: "10.12.5", arch: "x86_64", family: “mac"

I get 

"Sun Apr 11 00:00:00 CEST 1999"

instead of 

"Sat Apr 10 00:00:00 CEST 1999”

in JacksonMapperEnabledDefaultTyping_OBJECT_AND_NON_CONCRETE_Test#110

One minor point - the NOTICE file needs a bump to mention 2017

Thanks in advance,

Siegfried Goeschl


> On 14 Jul 2017, at 09:23, Siegfried Goeschl <[email protected]> 
> wrote:
> 
> Hi folks,
> 
> I will check on Sunday since I’m currently on holidays 
> 
> Thanks in advance,
> 
> Siegfried Goeschl
> 
>> On 12 Jul 2017, at 10:04, Jürgen Hoffmann <[email protected]> wrote:
>> 
>> Please verify this release candidate carefully and vote! 
>> 
>> [X] +1 release it 
>> [ ] +0 go ahead I don't care 
>> [ ] -1 no, do not release it because 
>> 
>> On 12. July 2017 at 08:41:36, Georg Kallidis ([email protected]) 
>> wrote:
>> 
>> Just a reminder for this unresolved release:  
>> 
>> Don´t hesitate to vote, positive or negative, with or without comment!  
>> 
>> Thanks a lot, Georg  
>> 
>> 
>> 
>> Von: "Georg Kallidis" <[email protected]>  
>> An: "Turbine Developers List" <[email protected]>,  
>> [email protected]  
>> Datum: 04.07.2017 15:46  
>> Betreff: [VOTE] Release fulcrum-json 1.1.1 based on staged  
>> repository  
>> 
>> 
>> 
>> Hi all,  
>> 
>> a new release candidate for the  
>> 
>> Fulcrum Json Component, version 1.1.1  
>> 
>> has been prepared.  
>> 
>> This is a multi module component:  
>> 
>> - modules are gson, jackson(1) and jackson2 - named after de/serializer  
>> types -, api and dist.  
>> - added new optional features for jsonpath and org.json (in jackson2).  
>> - updated gson, jackson versions (limited by java 6 requirements)  
>> 
>> Important notice:  
>> 
>> Please be aware, that next release may drop the Java 6 requirement!  
>> 
>> Please verify this release candidate carefully and vote!  
>> 
>> [ ] +1 release it  
>> [ ] +0 go ahead I don't care  
>> [ ] -1 no, do not release it because  
>> 
>> Tag:  
>> 
>> https://svn.apache.org/repos/asf/turbine/fulcrum/tags/fulcrum-json-1.1.1/  
>> 
>> 
>> Artifacts:  
>> 
>> https://repository.apache.org/content/repositories/orgapacheturbine-1022  
>> 
>> Any questions or discussions are always very welcome in the dev turbine  
>> list  
>> ([email protected]).  
>> 
>> 
>> Best regards,  
>> 
>> Georg  
>> 
>> 
>> 
>> ---------------------------------------------------------------------  
>> To unsubscribe, e-mail: [email protected]  
>> For additional commands, e-mail: [email protected]  
>> 
>> 
>> 
>> ---------------------------------------------------------------------  
>> To unsubscribe, e-mail: [email protected]  
>> For additional commands, e-mail: [email protected]  
>> 
>> 
>> -- 
>> Jürgen Hoffmann
>> Sent with Airmail
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 

Reply via email to