Hi folks, On 12.04.18 15:58, Georg Kallidis wrote: > default, not any hard-coded default. The locale based mimetype charset > check and set in this method could never be called IMO and may be better > moved to another place. It may be (re)used only optionally e.g. by setting > services.VelocityService.default.page to a class extending DefaultPage > overriding the method doBuildBeforeAction (calling rundata.setCharSet, per > request, executed in ExecutePageValve). As a result the charSet field > value in rundata is never set, which might be a problem, when the content > type does not match "text/".
I suggest to move the encoding/charset handling to a valve. That way, you can switch it on and off or change it as required. See my commit in r1836928. WDYT? Bye, Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
