.. sorry, this was not yet completed! I appreciate all the things you have done A LOT (very excited about your lightning talk !!), still reviewing...
@turbine-archetype: I 'll test it as soon as possible. We might add a .gitattributes to get rid of eol issues. The proposed Docker branch is still not yet completed, but if required I could check in the current state.. @fulcrums: Currently I have some changes in Fulcrum JSON, which I 'll check in soon and @releases: We might have to release Fulcrum components before Turbine 5 release? And (this might be better) before releasing Fulcrum Security wait for a Torque 4.1 release? And about the implications of Servlet API 4 - practically it would require Tomcat 9). Might there be any option to allow for Servlet 3.1 (does it make sense)? Best regards, Georg Von: "Georg Kallidis" <[email protected]> An: "Turbine Developers List" <[email protected]> Datum: 09.10.2018 09:34 Betreff: Re: Preparing for releases? Hi Jeff, I am .... Von: Jeffery Painter <[email protected]> An: Turbine Developers List <[email protected]> Datum: 08.10.2018 22:13 Betreff: Preparing for releases? So, you can see I have been busy. And I went back through the email archives and figured out how Georg had setup the archetype in apache gitbox. I merged my changes (forgive me Georg, but I get annoyed with line breaks that were built on MS machines - the diff was pretty large using dos2unix to convert them all, but I did merge your changes with mine before pushing up :-) ). Here is the merge of Georg's changes to archetype with Jeff's version if you want an easy review: https://github.com/jlpainter/turbine-webapp-5.0/commit/d1282ed29a4029ecdd6246cd1f3c232d66c26d29 I went through the Turbine fulcrum dependencies, updated findbugs where I could (there is still one in the equals method that I couldn't find a workaround for) and a few others. I mostly ignored those in test cases. fulcrum-pool had some nested classes that I refactored out to try and resolve a lot of the type checking issues going on. All the test cases are passing, but I am open to criticism if you disagree with my changes there. I still need to go back and identify those fulcrum components which should likely be marked dormant. I may have gotten over zealous with my global replace (I noticed several proposal/extension classes got updates that probably shouldn't, but I think it is mostly dead code). Please please let me know if I have overstepped anywhere. I want to be a good committer and not offend anyone :-) All that being said, I am pretty happy with the current state. I participated in the key signing event at ApacheCon that Jean-Frederic held, and I finally have my key authenticated by a few others who attended (published to keyring, in the pgp.mit.edu server, etc). I think the next step is for me to go back and re-read Georg's emails about preparing a release and start issuing some vote requests. Any help here would be appreciated.... I am guessing from Georg's silence the past 2 weeks he is out, but I am happy to wait until all are available to do a review of the updates I have made before proposing any votes. Let me know what you think. I am so happy I could finally contribute back (in hopefully a meaningful way), and if there are any other items you think we should check off before doing an initial 5.0 release, I am happy to help. I know we will need some work on the website... I think it is in a pretty messy state. I could spend some time on that as well. It could certainly use some simplification. Best, -- Jeff Painter CEO and Founder of JiveCast Software and analytics, made together https://jivecast.com 301 Fayetteville St. Unit 2301, Raleigh, NC 27601 (919) 533-9024 [Anhang "signature.asc" gelöscht von Georg Kallidis/CeDiS/FU-Berlin/DE]
smime.p7s
Description: S/MIME Cryptographic Signature
