Hi Georg,
> Am 02.11.2021 um 16:58 schrieb Georg Kallidis
> <[email protected]>:
>
> Hi Turbine developers,
>
> as Turbine and Fulcrum projects are now mostly with Git and synced in
> GitHub, PRs are enabled by default and we may encounter more code patches
> this way now than before.
>
.. which is a Good Thing (tm) in my opinion.
> How should we handle it? IMO as we're not a very big project, I'd suggest
> that any committer or PMC member could merge the PR, but she/he should
> leave a short comment and after that,
> if nobody from PMC or any committer does complain within a certain time, I
> would say about 24 to 48 hours, it could/will be merged.
>
My experience is that reviewing a PR is a simple thing to do - much easier than
reviewing commit diffs. As the merge creates a commit anyway, I think that any
committer can (and should) review and merge a pull request on its own
responsibility. I don't think we need a second reviewer, let alone the PMC.
> P.S. It may be, that there already a project or an Apache rule exists, but
> I am not aware of it - ..?
I believe that contributors at least must have a Contributor License Agreement
("CLA") on file. Don't know how to check that reliably.
Bye, Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
