Ok, I think I missed this ..
We still use version 0.14 of apache-rat-plugin (0.16 is now available), because
we inherit it from apache:apache:29 in our parent pom v12.
As a result, the rat report is not build, with rat-plugin v0.15 it is builds
again.
The build runs, if using Java 20 without this warning, and the report is build,
but another one is popping up (in site task probably):
java.lang.AbstractMethodError: Receiver class
org.codehaus.mojo.jdepend.JDependNoForkMojo does not define or inherit an
implementation of the resolved method 'abstract void
generate(org.apache.maven.doxia.sink.Sink, java.util.Locale)' of interface
org.apache.maven.reporting.MavenReport
- which results in not building the JDepend page (although version is still the
same 2.0). Additionally this issue in JDepend:
https://github.com/oshi/oshi/issues/1026 is affecting and is still unresolved.
Ok, this issue will come next time .. for now JDepend building and report is
still done ..
What things make worse is, that I overlooked (because of missing rat report?)
some missing licenses (due to this probably) in new Java classes.
Because of this I think I have change my vote to
[ x ] not release it, because license headers are missing in Java files (and
rat report is not generated, which causes this).
I have to amend the license headers anyway .. and will update in project pom
the rat plugin version to v0.15 to allow for a valid rat report.
I'll come back hopefully with another RC soon!
Thanks for checking this!
Best regards, Georg
-----Ursprüngliche Nachricht-----
Von: Jeffery Painter <[email protected]>
Gesendet: Samstag, 20. Januar 2024 19:35
An: [email protected]
Betreff: Re: [VOTE] New Turbine Core RC v6.0
Hello all,
I did get some warnings with this build, but they do not seem to be show
stopping.
System environment:
painter@merlin:~/apache/git/turbine-core$ cat /etc/lsb-release DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=23.10
DISTRIB_CODENAME=mantic
DISTRIB_DESCRIPTION="Ubuntu 23.10"
Java setup (1):
painter@merlin:~/apache/git/turbine-core$ mvn --version Apache Maven 3.9.5
(57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /usr/java/maven
Java version: 17.0.10, vendor: Oracle Corporation, runtime:
/usr/java/jdk-17.0.10
Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "6.5.0-14-generic",
arch: "amd64", family: "unix"
painter@merlin:~/apache/git/turbine-core$ mvn clean install site
...
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:24 min
[INFO] Finished at: 2024-01-20T13:26:59-05:00 [INFO]
------------------------------------------------------------------------
I switched to jdk-11 LTS and it removed nearly all of the errors:
Java setup (2):
painter@merlin:~/apache/git/turbine-core$ mvn -version Apache Maven 3.9.5
(57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: /usr/java/maven
Java version: 11.0.22, vendor: Oracle Corporation, runtime:
/usr/java/jdk-11.0.22
Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "6.5.0-14-generic",
arch: "amd64", family: "unix"
painter@merlin:~/apache/git/turbine-core$ mvn clean install site
...
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:18 min
[INFO] Finished at: 2024-01-20T13:30:32-05:00 [INFO]
------------------------------------------------------------------------
There is still one complaint at the end of the build even with JDK-11 setup:
[WARNING] An issue has occurred with apache-rat-plugin:0.14:rat report,
skipping LinkageError Receiver class org.apache.rat.mp.RatReportMojo does not
define or inherit an implementation of the resolved method abstract
generate(Lorg/codehaus/doxia/sink/Sink;Ljava/util/Locale;)V of interface
org.apache.maven.reporting.MavenReport., please report an issue to Maven dev
team.
java.lang.AbstractMethodError: Receiver class org.apache.rat.mp.RatReportMojo
does not define or inherit an implementation of the resolved method abstract
generate(Lorg/codehaus/doxia/sink/Sink;Ljava/util/Locale;)V of interface
org.apache.maven.reporting.MavenReport.
at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
(ReportDocumentRenderer.java:235)
at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
(DefaultSiteRenderer.java:348)
at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
(SiteMojo.java:194)
at org.apache.maven.plugins.site.render.SiteMojo.execute
(SiteMojo.java:143)
I don't think this is a show stopper though, so I give my vote:
[x] +1 release it!
Jeffery Painter
On 1/19/24 08:39, Kallidis, Georg wrote:
Hi Turbine devs,
a new Turbine Core release candidate has been prepared: version 6.0.
Tag: turbine-6.0
Git repo: https://gitbox.apache.org/repos/asf/turbine-core.git
Mirror: https://github.com/apache/turbine-core.git
N.B. If you do a checkout for a tag, you are in detached head mode, as you have
no branch to work on.
Artifacts:
https://repository.apache.org/content/repositories/orgapacheturbine-10
81
Changes in this version include:
o Provide a mechanism to allow auto loading of Turbine (and Fulcrum) services. If a
"known" service is extending FieldAnnotatedTurbineBaseService or
MethodAnnotatedTurbineBaseService it could declare fields and methods with more Turbine
annotations. Examples are annotating a service with @TurbineService or autoload a
service, which has class level annotation @TurbineService, if the callingclass itself is
TurbineService annotated.
o New service DateTimeFormatterService and tool DateTimeFormatterTool, which
allow date time formatting with locale and zone configuration.
o New profile rv-builds to build reproducible verifiable builds o
Dependency version updates include: yauaa to 7.24.0, commons-pool2 2.12.0,
slf4j-api 2.0.11, jaxb-runtime 4.0.4, fulcrum.security 3.0.0, fulcrum.intake
3.0.0, fulcrum.parser 3.0.0, fulcrum.yaafi 2.0.0, commons email to 1.6.0,
commons lang3 to 3.14.0, commons text to 1.11.0, (minor) version updates to
Torque 5.1, Jackson to 2.16.1 (yaml profile only), docker-testcontainers to
1.18.3 (docker profile only), commons-configuration2 to 2.8.0, commons-text
1.10.0.
o Fix java.lang.NoSuchFieldError: DEFAULT_TIME_BETWEEN_EVICTION_RUNS.
o Add Annotation @TurbineTool to annotate tools for advanced usage in action
methods.
This version supports Java 11 and above.
[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because
Please consider voting!
Thanks for the efforts ..
Best regards,
Georg
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
