Thanks, Jeffery!
While we wait for Thomas' vote I realized that this version and the last
Fulcrum component yaafi version may a major upgrade, that is 3.0.0 instead just
a patch update of 2.0.1 according to semantic versioning, because at least one
interface class ("Container) moved from testcontainer to yaafi component,
although it was previously not visible, but is now.
Sorry for the hassle, but I didn't thought about it not until now. I just
checked, if there exist a version hint plugin
(https://github.com/semantic-release/semantic-release does analyze commit
messages according to rules ("Following formalized conventions for commit
messages, semantic-release automatically determines the next semantic version
number"), which may be of some help in the future, if used from the beginning,
but it is a node extension) .. a maven plugin exists (maven-semantic-release),
but this is just for better understanding in the future ..
Apache release policy (https://www.apache.org/legal/release-policy.html ) does
not enforce semantic versioning as far as I can see.
If I read the semantic versioning paper more accurately, it says, that a major
version upgrade is required, when "backward incompatible changes" - we could
argue, that the new Container interface in Yaafi component does not exist
before and the old one in testcontainer module was used only internally in
classes of this same module (though it may have been used in other modules as
it was public) .
Do we agree to proceed nevertheless or should we restart the release?
With best regards, Georg
-----Ursprüngliche Nachricht-----
Von: Jeffery Painter <[email protected]>
Gesendet: Samstag, 12. Oktober 2024 18:50
An: [email protected]
Betreff: Re: [VOTE] Release fulcrum-testcontainer 2.0.1 based on staged
repository
Hi Turbine devs,
My vote:
[X] +1 release it
$ mvn version
Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /usr/java/maven
Java version: 17.0.9, vendor: Oracle Corporation, runtime:
/usr/java/jdk-17.0.9
Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version:
"6.8.0-45-generic", arch: "amd64", family: "unix"
$ mvn clean site install
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 12.396 s
[INFO] Finished at: 2024-10-12T12:48:20-04:00 [INFO]
------------------------------------------------------------------------
Signatures all check ok.
Thanks,
Jeffery
On 10/11/24 04:21, Kallidis, Georg wrote:
> Hi Turbine devs,
>
> A new release candidate in Fulcrum Testcontainer module has been prepared.
>
> Find it with this tag: fulcrum-testcontainer-2.0.1-candidate
>
> in Git repo:
> https://gitbox.apache.org/repos/asf/turbine-fulcrum-testcontainer.git
>
> Mirror:
> https://github.com/apache/turbine-fulcrum-testcontainer/tree/fulcrum-t
> estcontainer-2.0.1-candidate
>
> Example:
> git clone
> https://gitbox.apache.org/repos/asf/turbine-fulcrum-testcontainer.git
> cd turbine-fulcrum-testcontainer
> git checkout fulcrum-testcontainer-2.0.1-candidate
>
> N.B. If you checkout a tag, you are in detached head mode, as you have no
> branch to work on.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapacheturbine-10
> 90
>
> Important Changes:
>
> o Update junit jupiter version to 5.11.2, and mockito to 5.10.0,
> fulcrum-yaafi to 2.0.1, Turbine parent v13 o Move from javax to
> jakarta packages, servlet 6.x standard o Cleanup: remove container
> interface, remove Log4J2Logger - both now in fulcrum-yaafi
>
> This version requires by default Java 17.
>
> More details about releasing here:
> https://infra.apache.org/publishing-maven-artifacts.html#close-stage.
>
> Reply by checking one:
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
>
>
> Thanks!
>
>
> Best regards,
>
> Georg
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
