gmkll commented on PR #12: URL: https://github.com/apache/turbine-core/pull/12#issuecomment-3811658138
This is, how I understand it: By using JDK-9 System logger and log4j-jpl we (or users of Turbine core) may continue using log4j2, at least we still allow it in the same manner as we have now removed the Loggers in the core classes. Removing them was only done, to be less restrictive in Turbine -other tools or users may want to use log4j2 or not .. or the other way around, as we have now org.apache.turbine.log.Log Turbine framework (at its core at least) does use this Log(ger), of course :) We have to be aware, that log4j.xml is still needed and initialized, now much more elegantly with setting log4jConfiguration in Turbine / Jakarta WebServlet. That is also apparent by running the tests, log4j-test.xml is still evaluated correctly and writes to the right file .. I think this is an enhancement, and I would approve it, ending my review hereby. Thanks @tvand 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
