On Fri, Feb 6, 2009 at 9:31 AM, ant elder <[email protected]> wrote:

>
>
> On Fri, Feb 6, 2009 at 9:22 AM, Simon Laws <[email protected]>wrote:
>
>>
>>
>> On Fri, Feb 6, 2009 at 9:18 AM, <[email protected]> wrote:
>>
>>> Author: antelder
>>> Date: Fri Feb  6 09:18:59 2009
>>> New Revision: 741485
>>>
>>> URL: http://svn.apache.org/viewvc?rev=741485&view=rev
>>> Log:
>>> Simplify, these don't need to specify the logging properties now
>>>
>>> Modified:
>>>    tuscany/java/sca/samples/binding-ws-calculator/build.xml
>>>    tuscany/java/sca/samples/calculator-rmi-reference/build.xml
>>>    tuscany/java/sca/samples/calculator-rmi-service/build.xml
>>>
>>> Modified: tuscany/java/sca/samples/binding-ws-calculator/build.xml
>>> URL:
>>> http://svn.apache.org/viewvc/tuscany/java/sca/samples/binding-ws-calculator/build.xml?rev=741485&r1=741484&r2=741485&view=diff
>>>
>>> ==============================================================================
>>> --- tuscany/java/sca/samples/binding-ws-calculator/build.xml (original)
>>> +++ tuscany/java/sca/samples/binding-ws-calculator/build.xml Fri Feb  6
>>> 09:18:59 2009
>>> @@ -55,7 +55,6 @@
>>>               fork="true"
>>>                  inputstring="q"
>>>                  failonerror="true">
>>> -            <jvmarg
>>> value="-Djava.util.logging.config.file=${sample.root}/../../logging.properties"/>
>>>             <classpath>
>>>                <pathelement location="../../bin/launcher.jar"/>
>>>             </classpath>
>>>
>>> Modified: tuscany/java/sca/samples/calculator-rmi-reference/build.xml
>>> URL:
>>> http://svn.apache.org/viewvc/tuscany/java/sca/samples/calculator-rmi-reference/build.xml?rev=741485&r1=741484&r2=741485&view=diff
>>>
>>> ==============================================================================
>>> --- tuscany/java/sca/samples/calculator-rmi-reference/build.xml
>>> (original)
>>> +++ tuscany/java/sca/samples/calculator-rmi-reference/build.xml Fri Feb
>>>  6 09:18:59 2009
>>> @@ -55,7 +55,6 @@
>>>         <java classname="org.apache.tuscany.sca.launcher.LauncherMain"
>>>               fork="true"
>>>                  failonerror="true">
>>> -            <jvmarg
>>> value="-Djava.util.logging.config.file=${sample.root}/../../logging.properties"/>
>>>             <classpath>
>>>                <pathelement location="../../bin/launcher.jar"/>
>>>             </classpath>
>>>
>>> Modified: tuscany/java/sca/samples/calculator-rmi-service/build.xml
>>> URL:
>>> http://svn.apache.org/viewvc/tuscany/java/sca/samples/calculator-rmi-service/build.xml?rev=741485&r1=741484&r2=741485&view=diff
>>>
>>> ==============================================================================
>>> --- tuscany/java/sca/samples/calculator-rmi-service/build.xml (original)
>>> +++ tuscany/java/sca/samples/calculator-rmi-service/build.xml Fri Feb  6
>>> 09:18:59 2009
>>> @@ -57,7 +57,6 @@
>>>               fork="true"
>>>                  inputstring="\n"
>>>                  failonerror="true">
>>> -            <jvmarg
>>> value="-Djava.util.logging.config.file=${sample.root}/../../logging.properties"/>
>>>             <classpath>
>>>                <pathelement location="../../bin/launcher.jar"/>
>>>             </classpath>
>>>
>>>
>>> I'd quite like to keep these in as it's one less command line option to
>> have to remember. I just go in a change the logging properites file.
>>
>> Simon
>>
>
> Sure i do the same, but in r741481 this is now done in the launcher config
> file so they don't need to be in the sample build scripts. Its runtime
> configuration so the samples shouldn't need to care and this makes the build
> scripts simpler.
>
>    ...ant
>

Ok, as long as I'm not forced to type -Djava.util.logging.config.file etc.,
which being soft of mind I can never remember, that's alright.

Simon

Reply via email to