On Feb 12, 2009, at 12:44 AM, Luciano Resende wrote:

Please review and vote on the 2.0-M1 release artifacts of Tuscany SCA for Java.

The artifacts are available for review at:
http://people.apache.org/~lresende/tuscany/2.0-M1-RC3/

This includes the signed binary and source distributions, the RAT report,
and the Maven staging repository.

The release tag is available at :
http://svn.apache.org/repos/asf/tuscany/tags/java/sca/2.0-M1-RC3/


Looks OK to me, here is my +1.

First, thanks for the docs in the root src directory! The BUILDING/ README/RELEASE not to mention the LICENSE/NOTICE files will make it much easier for someone just picking up the source for the first time...

The following are the issues that I ran into. I guess I'm +0 on a release.

Raymond fixed a file that contained "http:..www" in the source license header. There was another file with the same problem. Raymond has fixed on trunk, also.

modules/databinding/src/main/java/org/apache/tuscany/sca/databinding/ xml/SAX2DOM.java has an old-style apache src license header. It should be updated.

I'm not able to build RC3 on Mac OS X:

[INFO] Building Apache Tuscany SCA Bin Distro Unzip
[INFO]    task-segment: [install]
[INFO] ------------------------------------------------------------------------
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:compile]
[INFO] No sources to compile
[INFO] [resources:testResources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:testCompile]
[INFO] No sources to compile
[INFO] [surefire:test]
[INFO] No tests to run.
[INFO] [jar:jar]
[INFO] Building jar: /Users/kevan/tuscany/tags/java/sca/2.0-M1-RC3/ itest/distribution/bin-distro-unzip/target/itest-bin-distro- unzip-2.0-M1.jar [INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) sun.jdk:tools:jar:1.6

  Try downloading the file manually from the project website.

  Then, install it using the command:
mvn install:install-file -DgroupId=sun.jdk -DartifactId=tools - Dversion=1.6 -Dpackaging=jar -Dfile=/path/to/file

Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=sun.jdk -DartifactId=tools - Dversion=1.6 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] - DrepositoryId=[id]

  Path to dependency:
        1) org.apache.maven.plugins:maven-antrun-plugin:maven-plugin:1.3
        2) sun.jdk:tools:jar:1.6

The Mac OS X Java 5 SDK has a different layout than other Java distributions and includes tools.jar classes n the normal runtime.

To fix, I couldn't find a good fix for the problem. So ended up either creating a dummy tools.jar file or by removing the work-around from itest/distribution/bin-distro-unzip/pom.xml:

Index: itest/distribution/bin-distro-unzip/pom.xml
===================================================================
--- itest/distribution/bin-distro-unzip/pom.xml (revision 743962)
+++ itest/distribution/bin-distro-unzip/pom.xml (working copy)
@@ -51,13 +51,13 @@
                         <version>1.6.5</version>
                     </dependency>
<!-- this JDk dependency is a workaround for Maven bug - http://jira.codehaus.org/browse/MNG-1323 -->
-                    <dependency>
-                        <groupId>sun.jdk</groupId>
-                        <artifactId>tools</artifactId>
-                        <version>1.6</version>
-                        <scope>system</scope>
- <systemPath>${java.home}/../lib/tools.jar</ systemPath>
-                    </dependency>
+<!--                     <dependency> -->
+<!--                         <groupId>sun.jdk</groupId> -->
+<!--                         <artifactId>tools</artifactId> -->
+<!--                         <version>1.6</version> -->
+<!--                         <scope>system</scope> -->
+<!-- <systemPath>${java.home}/../lib/ tools.jar</systemPath> -->
+<!--                     </dependency> -->
                 </dependencies>

                 <executions>

Also, I'm unable to build using Java 6. Is everyone using Java 5? Or is this another Mac OS feature?

All samples are working for me.

--kevan

Reply via email to