Hi Ram

snip....

>> The question seems to me... Do we set the contribution classloader
>> into TCCL before we call the component implementation? Maybe I'm
>> missing something.
>
> I see that in the current code, we don't set a contribution classloader. The
> classLoader
> field in the ContributionImpl instance is always null.

Not sure if this is important or not. In the implementation invoker we
need to set TCCL to the contribution classloader that loaded the
implementation class we are about to call. So how to get the
contribution and it's classloader for the class we are about to call.
The easy way is to get the classloader from the class and set that of
course. I don't know if no changes have been made to make this work or
that some changes have been made but that something was missed out.

> We also have a
> ContributionClassLoader class
> which never seems to be used.

If there are things that we don't use in 2.x I think we should remove
them. I'd like to think that we are aiming for as clean a code base as
possible.

Simon

Reply via email to