[ https://issues.apache.org/jira/browse/TUSCANY-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064897#comment-13064897 ]
ant elder commented on TUSCANY-3896: ------------------------------------ Thanks for the patch. I think there could be potential for confusion having a setter method that sometimes invisibly doesn't actually do any setting so how about instead adding a getSCAClientFactoryFinder method and have the SCAClientModuleActivator use that to see if the value is null before calling setSCAClientFactoryFinder? > Enable subclassing of SCAClientFactoryImpl > ------------------------------------------ > > Key: TUSCANY-3896 > URL: https://issues.apache.org/jira/browse/TUSCANY-3896 > Project: Tuscany > Issue Type: Improvement > Affects Versions: Java-SCA-2.0 > Reporter: Greg Dritschler > Priority: Minor > Attachments: TUSCANY-3896.patch > > > org.apache.tuscany.sca.client.impl.SCAClientFactoryImpl has a private method > findLocalRuntime() which attempts to find an existing Tuscany runtime in the > same JVM. If it cannot find one, it creates a Tuscany runtime for the client. > When Tuscany is embedded into a server environment, the host environment may > want greater control over how the local runtime is discovered or created. It > could do so by subclassing SCAClientFactoryImpl and overriding the > findLocalRuntime() method. > I am attaching a patch that changes findLocalRuntime(), along with related > member variables, from private to protected. > The patch also changes setSCAClientFactoryFinder() so that it does not change > the factory finder implementation if the host has already set one. > The patch also fixes a Java2 security problem that may happen with the use of > getClassLoader(). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira