[
https://issues.apache.org/jira/browse/TUSCANY-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100685#comment-13100685
]
Scott Kurz commented on TUSCANY-3943:
-------------------------------------
Eric,
Thanks for raising the issue and the patch. In r1166896, I added a test to
interface-wsdl showing this issue, @Ignore(d) for now.
A couple comments on your patch. It's a good start, I did have to tweak it a
bit since it assumes I'm going to have a <jaxws:package> customization in my
WSDL
along with the <jaxws:enableWrapperStyle> customization (which my test in
particular did not have).
But I basically made my test pass by tweaking the one line to:
Node wrapperElem =
element.getElementsByTagNameNS(jaxwsNS,wrapperTagName).item(0);
I'm not sure at this point what to make of your comment about needing to tweak
wsdlgen. Can you outline at least (if not post) the test you used to reach
this conclusion?
Also, while we might want to read and honor the <jaxws:package> customization
(as well as others) at some point, my preference would be to leave this out
altogether unless we are really going to make use of this in a real scenario.
If we don't have a test which makes uses of this at least, let's cut that out
so any maintainers of this code have less to worry about.
If you can resubmit a trimmed-down patch which passes the new test, I can
commit it.
I'll let you decide whether you want to use this or another JIRA to address the
wsdlgen issue as well.
Thanks,
Scott
> JAXWS Elements are not processed by the WSDLModelResolver -
> enableWrapperStyle elements are ignored
> ---------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-3943
> URL: https://issues.apache.org/jira/browse/TUSCANY-3943
> Project: Tuscany
> Issue Type: Improvement
> Components: SCA Java Runtime
> Environment: All systems
> Reporter: Eric Larsen
> Fix For: Java-SCA-2.x
>
> Attachments: binding-ws-wsdlgen.patch, interface-wsdl.patch
>
>
> Tuscany doesn't process any jaxws tags that are included in WSDL files. This
> causes any enableWrapperStyle elements to be ignored, which causes a logic
> failure in the wrapping logic when Tuscany expects wrapped objects, and Java
> classes generated by external tools such as wsimport are not wrapped.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
