Hi, Btw, thanks for your great effort to become compatible with ASF at releases!
Kind Regards, Furkan KAMACI On Mon, Dec 2, 2019 at 10:38 PM Furkan KAMACI <[email protected]> wrote: > Hi Antoine, > > ProgPoW.java has the same header that's been fixed at SECP256K1.java? > > Kind Regards, > Furkan KAMACI > > On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <[email protected]> > wrote: > >> I made sure all steps were clear as of 3). That’s why I had 0.8.0, 0.8.1, >> 0.8.2. We went all over this. Which one do you see is not compliant? >> >> > On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <[email protected]> >> wrote: >> > >> > Hi, >> > >> > +1 from me. >> > >> > I checked: >> > >> > - Incubating in name >> > - DISCLAIMER exists >> > - LICENSE and NOTICE are fine >> > - No unexpected binary files >> > - Checked PGP signatures >> > - Checked Checksums >> > - Code compiles and tests successfully run >> > >> > Comments: >> > >> > 1) You should fix build instructions to include minimum required Java 8 >> > minor version. >> > 2) Tidy up indentation of DISCLAIMER. See >> > https://github.com/apache/incubator-druid/blob/master/DISCLAIMER >> > 3) Please be sure that "all" steps are OK at here: >> > >> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E >> > >> > Kind Regards, >> > Furkan KAMACI >> > >> > On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <[email protected]> >> wrote: >> > >> >> You’re using a very old version of JDK8, and the later versions behave >> >> differently. >> >> >> >> This tells me we need to move to Java 11. >> >> >> >>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <[email protected]> >> >> wrote: >> >>> >> >>> Hi, >> >>> >> >>> I still get the same error as previous version: >> >>> >> >> >> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E >> >>> >> >>> Kind Regards, >> >>> Furkan KAMACI >> >>> >> >>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <[email protected]> >> >> wrote: >> >>> >> >>>> looks good >> >>>> +1 >> >>>> >> >>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <[email protected]> >> >> wrote: >> >>>> >> >>>>> We're voting on the distributions available here: >> >>>>> >> >>>> >> >> >> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/ >> >>>>> The release tag is present here: >> >>>>> >> >>>> >> >> >> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating >> >>>>> >> >>>>> This release includes the following changes: >> >>>>> • Added discv5 >> >>>>> • Bytes fixes and enhancements >> >>>>> • Fixes and minor enhancements to UInt256 >> >>>>> >> >>>>> Here’s my +1. >> >>>>> >> >>>>> Cheers, >> >>>>> >> >>>>> Antoine >> >>>>> >> >>>>> >> >>>>> >> >>>>> >> --------------------------------------------------------------------- >> >>>>> To unsubscribe, e-mail: [email protected] >> >>>>> For additional commands, e-mail: [email protected] >> >>>>> >> >>>>> >> >>>> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
