franck44 opened a new issue #49: SSZ encoding of list of booleans URL: https://github.com/apache/incubator-tuweni/issues/49 The encoding (serialisation) fo list of booleans seem to produce 1. a unit32 with the size of the list 2. a sequence of Bytes each one encoding a bit in the list. This is according to the implementation https://github.com/apache/incubator-tuweni/blob/03c08eeeba108670938252fef1fee209bdf435fe/ssz/src/main/java/org/apache/tuweni/ssz/SSZ.java#L1221 and test https://github.com/apache/incubator-tuweni/blob/03c08eeeba108670938252fef1fee209bdf435fe/ssz/src/test/java/org/apache/tuweni/ssz/BytesSSZWriterTest.java#L415 If this is correct, it does not seem to correctly implement the format of the Eth2.0 spec https://github.com/ethereum/eth2.0-specs/blob/dev/ssz/simple-serialize.md#bitlistn which specifies that the bits should be put together in Bytes (which seems to a good idea as produces more compact encodings). Is that going to be problem when communicating with clients that do implement the spec?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
