I’m a bit at a loss as to what to do. Would other mentors step up and try the distribution?
> On Mar 2, 2020, at 10:41 AM, Antoine Toulme <[email protected]> wrote: > > I don’t have a Windows machine to test on. > > My best bet is that you’re seeing issues with spotless and newline characters. > I mean, spotless is complaining about every single line of the checkout. > > Cheers, > > Antoine > >> On Mar 1, 2020, at 6:24 PM, Michael Wall <[email protected]> wrote: >> >> Antoine, >> >> Thanks for looking. Here is what I am currently getting after running >> >> gradle.bat setup >> gradlew.bat clean build test >> >> ---------- >>> Task :licenseMain NO-SOURCE >>> Task :licenseTest NO-SOURCE >>> Task :license UP-TO-DATE >>> Task :spotlessGroovyGradle FAILED >> >> FAILURE: Build failed with an exception. >> >> * What went wrong: >> Execution failed for task ':spotlessGroovyGradle'. >>> The following files had format violations: >> build.gradle >> @@ -1,605 +1,605 @@ >> -/*\n >> - * Licensed to the Apache Software Foundation (ASF) under one or >> more contributor license agreements. See the NOTICE\n >> - * file distributed with this work for additional information >> regarding copyright ownership. The ASF licenses this file\n >> - * to You under the Apache License, Version 2.0 (the "License"); >> you may not use this file except in compliance with the\n >> - * License. You may obtain a copy of the License at\n >> - *\n >> - * http://www.apache.org/licenses/LICENSE-2.0\n >> - *\n >> - * Unless required by applicable law or agreed to in writing, >> software distributed under the License is distributed on\n >> - * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> KIND, either express or implied. See the License for the\n >> - * specific language governing permissions and limitations under >> the License.\n >> - */\n >> -import org.ajoberstar.grgit.Grgit\n >> -import java.time.Instant\n >> -import java.time.ZoneId\n >> -import java.time.format.DateTimeFormatter\n >> -import java.time.format.FormatStyle\n >> -import java.util.regex.Pattern\n >> -import net.ltgt.gradle.errorprone.CheckSeverity\n >> -\n >> -buildscript {\n >> - repositories { jcenter() // jcenter\n >> - }\n >> -\n >> - dependencies { classpath >> "org.ajoberstar.grgit:grgit-core:3.1.1" }\n >> -}\n >> -\n >> -plugins {\n >> - id 'com.diffplug.gradle.spotless' version '3.16.0'\n >> - id 'net.ltgt.errorprone' version '0.6'\n >> - id 'io.spring.dependency-management' version '1.0.6.RELEASE'\n >> - id 'com.github.hierynomus.license' version '0.15.0'\n >> - id 'org.gradle.crypto.checksum' version '1.1.0'\n >> - id 'org.jetbrains.kotlin.jvm' version '1.3.30'\n >> - id 'org.jetbrains.dokka' version '0.10.0'\n >> - id 'maven-publish'\n >> - id 'com.jfrog.bintray' version '1.8.3'\n >> -}\n >> -\n >> -description = 'A set of libraries and other tools to aid >> development of blockchain and other decentralized software in Java and >> other JVM languages'\n >> -\n >> -//////\n >> -// Sanity checks\n >> -if >> (!file("${rootDir}/eth-reference-tests/src/test/resources/eth2.0-tests/README.md").exists()) >> {\n >> - throw new >> GradleException("eth-reference-tests/src/test/resources/eth2.0-tests/README.md >> missing: please clone submodules (git submodule update --init >> --recursive)")\n >> -}\n >> -\n >> -if >> (!file("${rootDir}/eth2-reference-tests/src/test/resources").exists()) {\n >> ... (1162 more lines that didn't fit) >> Violations also present in 42 other files. >> Run 'gradlew spotlessApply' to fix these violations. >> >> * Try: >> Run with --stacktrace option to get the stack trace. Run with --info or >> --debug option to get more log output. Run with --scan to get full insights. >> >> * Get more help at https://help.gradle.org >> >> BUILD FAILED in 2m 58s >> 103 actionable tasks: 103 executed >> --------- >> >> I again tested in command prompt and git-bash. >> >> I can try building on Linux tomorrow. >> >> Mike >> >> On Sun, Mar 1, 2020 at 9:14 PM Michael Wall <[email protected]> wrote: >> >>> Yeah, looks like the zip had issues extracting. Expanding the tgz worked >>> better. Building now. >>> >>> On Sun, Mar 1, 2020 at 9:04 PM Antoine Toulme <[email protected]> wrote: >>> >>>> I tried to build with the zip file, and it worked ok. >>>> >>>> This doesn’t seem to be a forward path issue. >>>> >>>> Do you reproduce with the tar.gz archive as well? >>>> >>>> Cheers, >>>> >>>> Antoine >>>> >>>>> On Mar 1, 2020, at 5:59 PM, Antoine Toulme <[email protected]> wrote: >>>>> >>>>> Thanks for checking Michael. >>>>> >>>>> Is the file eth2-reference-tests/src/test/resources present in the >>>> checkout? >>>>> The new src artifact is now so big that the zip file is using the zip64 >>>> format, so there a chance it might not have unzipped well under Windows. >>>>> >>>>> You’re using Windows - which version of Windows? This might be a >>>> forward slash vs backward slash in path problem. >>>>> >>>>> Cheers, >>>>> >>>>> Antoine >>>>> >>>>>> On Mar 1, 2020, at 5:53 PM, Michael Wall <[email protected]> wrote: >>>>>> >>>>>> Signatures look fine, spot check licenses was fine. >>>>>> >>>>>> Got this when I tried unzipped the src and tried to build >>>>>> >>>>>> --- >>>>>> gradle setup >>>>>> >>>>>> Welcome to Gradle 6.2.1! >>>>>> >>>>>> Here are the highlights of this release: >>>>>> - Dependency checksum and signature verification >>>>>> - Shareable read-only dependency cache >>>>>> - Documentation links in deprecation messages >>>>>> >>>>>> For more details see https://docs.gradle.org/6.2.1/release-notes.html >>>>>> >>>>>> Starting a Gradle Daemon (subsequent builds will be faster) >>>>>> >>>>>> FAILURE: Build failed with an exception. >>>>>> >>>>>> * Where: >>>>>> Build file >>>>>> >>>> 'C:\Users\mjwal\Desktop\tuweni-1.0.0\tuweni-src-1.0.0-incubating\tuweni-src-1.0.0\build.gradle' >>>>>> line: 49 >>>>>> >>>>>> * What went wrong: >>>>>> A problem occurred evaluating root project 'tuweni'. >>>>>>> >>>>>> >>>> C:\Users\mjwal\Desktop\tuweni-1.0.0\tuweni-src-1.0.0-incubating\tuweni-src-1.0.0/eth2-reference-tests/src/test/resources >>>>>> missing: please clone submodules (git submodule update --init >>>> --recursive) >>>>>> >>>>>> * Try: >>>>>> Run with --stacktrace option to get the stack trace. Run with --info or >>>>>> --debug option to get more log output. Run with --scan to get full >>>> insights. >>>>>> >>>>>> * Get more help at https://help.gradle.org >>>>>> >>>>>> BUILD FAILED in 30s >>>>>> >>>>>> On Sun, Mar 1, 2020 at 8:27 PM Antoine Toulme <[email protected]> >>>> wrote: >>>>>> >>>>>>> Thanks for confirming. >>>>>>> >>>>>>>> On Mar 1, 2020, at 5:48 AM, Michael Wall <[email protected]> wrote: >>>>>>>> >>>>>>>> I can take a look this afternoon. >>>>>>>> >>>>>>>> Per https://incubator.apache.org/policy/incubation.html#releases, >>>>>>> releases >>>>>>>> still need to be approved on the general@incubator list and should >>>> be at >>>>>>>> least 72 hours per >>>>>>>> >>>>>>> >>>> https://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions >>>>>>> . >>>>>>>> This gives IPMC members a chance to comment. >>>>>>>> >>>>>>>> Some projects do not get mentor votes before sending to >>>> general@incubator >>>>>>> , >>>>>>>> and those votes can last longer than 72 hours while they wait to get >>>> 3 >>>>>>>> binding votes. >>>>>>>> >>>>>>>> On Sat, Feb 29, 2020 at 11:53 AM Antoine Toulme <[email protected] >>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>>> Again, if a mentor would please vote on the release, that would be >>>>>>>>> appreciated. >>>>>>>>> >>>>>>>>> Sorry for the insistance. Without 3 mentor votes, we would need to >>>> run a >>>>>>>>> second vote on the incubator mailing list. Please correct me if I am >>>>>>> wrong. >>>>>>>>> >>>>>>>>>> On Feb 27, 2020, at 08:13, Jonny Rhea <[email protected]> >>>> wrote: >>>>>>>>>> >>>>>>>>>> +1 >>>>>>>>>> >>>>>>>>>>> On Sun, Feb 23, 2020, 11:43 PM Antoine Toulme < >>>> [email protected]> >>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> We're voting on the distributions available here: >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.0.0-incubating/ >>>>>>>>>>> The release tag is present here: >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>> https://github.com/apache/incubator-tuweni/releases/tag/v1.0.0-incubating >>>>>>>>>>> >>>>>>>>>>> This release includes the following changes: >>>>>>>>>>> * Moved to JDK11 support by default. 1.0.0 drops support for JDK8. >>>>>>>>>>> * Added ethnetstats library. >>>>>>>>>>> * Added key-value store functionalities: proxy store, stores are >>>> now >>>>>>>>>>> generic, not just bytes, and have the ability to iterate over >>>> keys or >>>>>>>>> clear >>>>>>>>>>> their contents. >>>>>>>>>>> * Added support for JPA-backed key value stores >>>>>>>>>>> * Added eth2 reference tests repository. This repository is >>>> checked >>>>>>> out >>>>>>>>> as >>>>>>>>>>> a submodule, and will be used to test SSZ going forward. >>>>>>>>>>> * Fix TUWENI-30: expose key for GenericHash >>>>>>>>>>> * Allow CN as option when generating the self-signed certs (used >>>> to be >>>>>>>>>>> example.com) >>>>>>>>>>> * Move Jenkins build to Jenkinsfile inside the repo. >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> >>>>>>>>>>> Antoine >>>>>>>>>>> >>>> --------------------------------------------------------------------- >>>>>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>> --------------------------------------------------------------------- >>>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>> For additional commands, e-mail: [email protected] >>>>>>> >>>>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
