This is from the distribution. Introducing Docker helped standardize the build experience. The underlying issue is that we got in trouble early on for shipping with the gradle wrapper.
We followed the approach of Apache Kafka and introduced a gradle setup task, which feels backward, but here we are. Two options in my mind: * We require Docker and we patch build.sh to build the build image on demand. * We revert and put back the old instructions requiring people to install Java and Gradle before they try to build. I’d go middle of the road and try to offer both. I’ll fix build.sh right now. > On Jun 20, 2020, at 9:39 AM, Danno Ferrin <[email protected]> wrote: > > Q: is this from a git clone or from the distribution sources zip? > > The docker build was put in place to allow building on windows and on Java > versions past Java 11. Recently I posted patches to fix those. Were there > any other reasons? Would an acceptable fix be to make the build.sh run > gradle in host rather than gradle in docker? > > The other alternative is to bring the needed docker files into the src jar. > > Weakly held, but my preference would be to remove docker as a build step > and update build.sh. This isn't a project directly integrating with docker > so I don't think docker is essential. I would prefer to directly address > the build issues rather than hide them with a docker build. > > On Sat, Jun 20, 2020 at 10:29 AM Furkan KAMACI <[email protected]> > wrote: > >> Hi, >> >> -1 from me. >> >> I checked: >> >> - Incubating in name >> - DISCLAIMER exists >> - LICENSE and NOTICE are fine >> - No unexpected binary files >> - Checked PGP signatures >> - Checked Checksums >> - Could not compile from ./build.sh even when Docker is running. >> >> My opinion is you should fix the build error first. >> >> Kind Regards, >> Furkan KAMACI >> >> On Sat, Jun 20, 2020 at 4:36 AM Steven J Schroeder <[email protected]> wrote: >> >>> +1 >>> >>> On Tue, Jun 16, 2020, 02:33 Antoine Toulme <[email protected]> wrote: >>> >>>> We're voting on the source distributions available here: >>>> >>> >> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/ >>>> The release tag is present here: >>>> >>> >> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating >>>> >>>> This release includes the following changes: >>>> >>>> New: >>>> * Implement DNS discovery reader, reading from goerli and mainnet >>>> * Implement #71 - short hash string >>>> * Implement #72 - Upgrade codec dependency by @ajsutton >>>> * #74 and #75 enhance UInt256 performance by @shemnon >>>> >>>> Changes: >>>> * Move to slf4j from logl >>>> * Simplify address and hash classes >>>> * Expose the ability to destroy public keys directly >>>> >>>> Bug fixes: >>>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if >>>> fingerPrintFile has no parent Dir >>>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items >>>> * Fix for issue #82 - Fix Windows tests by @shemnon >>>> >>>> Misc: >>>> * Adopt github actions to run CI >>>> * Upgrade to Gradle 6.3 >>>> * Fix for issue #63 docker to build >>>> >>>> Cheers, >>>> >>>> Antoine >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
