Hello all, The vote has concluded and the results are as follows: 4 +1: Antoine Toulme Danno Ferrin Furkan Kamaci Michael Wall 0 +0 0 -1
The release vote passes. I will now open a new vote on the incubator list. Cheers, Antoine > On Jul 4, 2020, at 12:26 PM, Antoine Toulme <[email protected]> wrote: > > I heard from JB off list that he might have time to take a look. I’m leaving > the vote open for this week-end, hoping he gets a chance to look. > > Cheers, > > Antoine > >> On Jul 1, 2020, at 8:36 AM, Antoine Toulme <[email protected]> wrote: >> >> Mike, >> >> Thank you for the feedback. I am going to add a new CI job on Windows with >> GitHub actions to test this for the next release. >> >> Cheers, >> >> Antoine >> >>> On Jul 1, 2020, at 6:35 AM, Michael Wall <[email protected]> wrote: >>> >>> +1 >>> >>> Good >>> - LICENSE and NOTICE >>> - Incubating in name >>> - sha512 and asc checked >>> - no unexpected binaries >>> - I was able to build manually with the docker image >>> >>> Bad >>> - Still did not build on windows, see [1] and [2] below >>> - Why so many artifacts in >>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/ >>> if you are only interested in the src release? I had to check them >>> all >>> - tuweni-bin had .asc files beside all the jars in the lib directory >>> >>> Thanks, good work >>> >>> Mike >>> >>> 1 - Still having problems building with gradle on windows >>> ``` >>> D:\Code\apache\tuweni-1.1.0\tuweni-src-1.1.0 >>> λ .\gradlew.bat build >>>> Task :spotlessGroovyGradle FAILED >>> >>> FAILURE: Build failed with an exception. >>> >>> * What went wrong: >>> Execution failed for task ':spotlessGroovyGradle'. >>> ``` >>> I ran git init in the directory and then ran `gradlew.bat >>> spotlessApply`. The only changes in git were line endings. Didn't >>> look any further >>> >>> 2 - Docker build is close but build.sh doesn't work on windows. I did >>> get it build using the following for reference >>> ``` >>> cd gradle\docker\ >>> docker build -t tuweni_test -f test.Dockerfile ..\.. >>> cd ..\.. >>> docker run -v >>> D:\Code\apache\tuweni-1.1.0\tuweni-src-1.1.0\build\libs\:/home/gradle/build/libs >>> tuweni_test bash -c "gradle -Dorg.gradle.jvmargs=\"-Xmx2g >>> -XX:MaxMetaspaceSize=512m\" assemble" >>> ``` >>> >>> On Wed, Jul 1, 2020 at 3:18 AM Antoine Toulme <[email protected]> wrote: >>>> >>>> Thanks! I will wait for Mike to cast his vote. JB, if you’d be so kind as >>>> to vote as well, we can issue the release faster then. >>>> >>>> Cheers, >>>> >>>> Antoine >>>> >>>>> On Jun 30, 2020, at 2:11 PM, Furkan KAMACI <[email protected]> wrote: >>>>> >>>>> Hi, >>>>> >>>>> +1 from me. >>>>> >>>>> I checked: >>>>> >>>>> - Incubating in name >>>>> - DISCLAIMER exists >>>>> - LICENSE and NOTICE are fine >>>>> - No unexpected binary files >>>>> - Checked PGP signatures >>>>> - Checked Checksums >>>>> - Code compiles and tests successfully run (I've tried both docker and >>>>> gradle builds). >>>>> >>>>> Kind Regards, >>>>> Furkan KAMACI >>>>> >>>>> On Tue, Jun 30, 2020 at 8:10 PM Michael Wall <[email protected]> wrote: >>>>> >>>>>> Will look tonight >>>>>> >>>>>> Mike >>>>>> >>>>>> On Tue, Jun 30, 2020, 13:08 Antoine Toulme <[email protected]> wrote: >>>>>> >>>>>>> We require one more vote to close the release. Would anyone have time to >>>>>>> try it out and vote? >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Antoine >>>>>>> >>>>>>>> On Jun 28, 2020, at 5:41 PM, Antoine Toulme <[email protected]> >>>>>> wrote: >>>>>>>> >>>>>>>> Any mentor interested in casting a vote, please let us know. I will >>>>>>> close the vote tomorrow. >>>>>>>> >>>>>>>> Antoine >>>>>>>> >>>>>>>>> On Jun 26, 2020, at 6:10 PM, Antoine Toulme <[email protected]> >>>>>>> wrote: >>>>>>>>> >>>>>>>>> The signatures match. The Maven staging repository closed OK on Nexus. >>>>>>>>> >>>>>>>>> +1 >>>>>>>>> >>>>>>>>>> On Jun 26, 2020, at 7:50 AM, Danno Ferrin <[email protected]> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> +1 >>>>>>>>>> >>>>>>>>>> On Fri, Jun 26, 2020 at 1:53 AM Antoine Toulme <[email protected]> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> We're voting on the source distributions available here: >>>>>>>>>>> >>>>>>> >>>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/ >>>>>>>>>>> < >>>>>>> >>>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.1.0-incubating/ >>>>>>>>>>>> >>>>>>>>>>> The release tag is present here: >>>>>>>>>>> >>>>>>> >>>>>> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating >>>>>>>>>>> < >>>>>>> >>>>>> https://github.com/apache/incubator-tuweni/releases/tag/v1.1.0-incubating >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> This release includes the following changes: >>>>>>>>>>> >>>>>>>>>>> New: >>>>>>>>>>> * Implement DNS discovery reader, reading from goerli and mainnet >>>>>>>>>>> * Implement #71 - short hash string >>>>>>>>>>> * Implement #72 - Upgrade codec dependency by @ajsutton >>>>>>>>>>> * #74 and #75 enhance UInt256 performance by @shemnon >>>>>>>>>>> >>>>>>>>>>> Changes: >>>>>>>>>>> * Move to slf4j from logl >>>>>>>>>>> * Simplify address and hash classes >>>>>>>>>>> * Expose the ability to destroy public keys directly >>>>>>>>>>> >>>>>>>>>>> Bug fixes: >>>>>>>>>>> * Fix for issue #50 - FileBackedFingerprintRepository throws NPE if >>>>>>>>>>> fingerPrintFile has no parent Dir >>>>>>>>>>> * Fix for issue #78 - Dist tar.gz and zip contain duplicate items >>>>>>>>>>> * Fix for issue #82 - Fix Windows tests by @shemnon >>>>>>>>>>> >>>>>>>>>>> Misc: >>>>>>>>>>> * Adopt github actions to run CI >>>>>>>>>>> * Upgrade to Gradle 6.3 >>>>>>>>>>> * Fix for issue #63 docker to build >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> >>>>>>>>>>> Antoine >>>>>>>>> >>>>>>>>> >>>>>>>>> --------------------------------------------------------------------- >>>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>> >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>> For additional commands, e-mail: [email protected] >>>>>>> >>>>>>> >>>>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
