----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21988/#review44484 -----------------------------------------------------------
Ship it! Looks good to me. Will merge it. - Terence Yim On May 28, 2014, 8:38 p.m., Erick Tryzelaar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21988/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 8:38 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > This patch series fixes a couple minor issues: > > * maven-javadoc-plugin was reporting errors due to the embedded HTML in some > documentation. This fixes those issues. > * HelloWorld example should exit if not passed the right arguments > * Include twill-examples in the pom modules list > * Fix some typos. > * Add a .reviewboardrc to simplify submitting patches. This draws inspiration > from http://aurora.incubator.apache.org/docs/howtocontribute. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > pom.xml 8535d49fcc8c353ff6d442487f047577f87619a8 > > twill-discovery-core/src/main/java/org/apache/twill/discovery/ZKDiscoveryService.java > f29d9864c3d524b4a62767224735b5a380d33b8a > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/HelloWorld.java > 8dc83ff24f02e946405bfb051b194d5c39bb2618 > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > 6b9a15d5e71cd134671c415b2029905a71a69088 > twill-yarn/src/main/java/org/apache/twill/internal/ContainerExitCodes.java > 22576a9980bc0fee58681c7689b1622989cc2d32 > > Diff: https://reviews.apache.org/r/21988/diff/ > > > Testing > ------- > > Ran the built in tests. > > > Thanks, > > Erick Tryzelaar > >
