[
https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429758#comment-15429758
]
ASF GitHub Bot commented on TWILL-182:
--------------------------------------
Github user serranom commented on the issue:
https://github.com/apache/twill/pull/1
Fixed these and some other checkstyle related parts. I was running full
builds but was not seeing the checkstyle failures. I'm not sure what mistake I
made. Anyway, these issues are now fixed. Thanks for your patience as I get
to know the project. Also, twill-core has these checkstyle warnings but a
failure is not triggered:
[INFO] --- maven-checkstyle-plugin:2.12.1:check (validate) @ twill-core
---
[INFO] Starting audit...
/home/martin/dev/other/twill/twill-
core/src/main/java/../java/org/apache/twill/internal/state/SystemMessages.java:22:
warning: Wrong order for 'com.google.common.base.Preconditions' import.
/home/martin/dev/other/twill/twill-core/src/test/java/org/apache/twill/internal/DebugOptionsTest.java:26:
warning: First sentence should end with a period.
Audit done.
> ApplicationBundler will overwrite dependencies with identical names
> -------------------------------------------------------------------
>
> Key: TWILL-182
> URL: https://issues.apache.org/jira/browse/TWILL-182
> Project: Apache Twill
> Issue Type: Bug
> Components: core
> Affects Versions: 0.7.0-incubating
> Reporter: Martin Serrano
> Fix For: 0.8.0
>
>
> If two jars obtained from *different* classpath locations have the same name
> but different contents, one will overwrite the other. The dependency code
> correctly finds the jars (uses the full path in the HashSet which accumulates
> the deps) but when the bundle is created the jars are written to {{/lib}}
> under their name. This results in one overwriting the other.
> While this is not a likely occurrence, it occurs for us in our development
> environment because our published jar names are built up from their project
> hierarchy. For example the model project for our sdk is in {{.../sdk/model}}
> and will be on the classpath as {{.../sdk/model.jar}} and published as
> {{sdk-model.jar}}.
> In practice however this could occur with any jar name and would be more
> likely over time.
> The {{ApplicationBundler}} could detect this and re-write the name with some
> part of the path or suffix to ensure the name is unique.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
