[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437557#comment-15437557
]
ASF GitHub Bot commented on TWILL-190:
--------------------------------------
GitHub user poornachandra opened a pull request:
https://github.com/apache/twill/pull/4
TWILL-190 Wait for Twill runnables to stop when restarting them
Also kill non-responding Twill runnables after a timeout.
JIRA - https://issues.apache.org/jira/browse/TWILL-190
Opening against master this time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/poornachandra/twill feature/kill-runnable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 740a144026b79903cf1460be447e88cfa8b7ea1d
Author: poorna <poo...@cask.co>
Date: 2016-08-17T08:12:36Z
TWILL-190 Wait for Twill runnables to stop when restarting them, also kill
non-responding Twill runnables after a timeout
commit 1941ddf38836787bedfcfec834962398f624c204
Author: poorna <poo...@cask.co>
Date: 2016-08-25T20:08:36Z
Reduce wait time when stopping or killing a runnable
----
> Restart of a TwillRunnable does not wait for the runnable to stop
> -----------------------------------------------------------------
>
> Key: TWILL-190
> URL: https://issues.apache.org/jira/browse/TWILL-190
> Project: Apache Twill
> Issue Type: Bug
> Components: core, yarn
> Affects Versions: 0.6.0-incubating, 0.7.0-incubating
> Reporter: Poorna Chandra
> Assignee: Poorna Chandra
> Fix For: 0.8.0
>
>
> Today when a TwillRunnable is restarted, the call sends a stop message to the
> TwillRunnable, and then starts new TwillRunnable without waiting for the
> stopping runnable to finish stopping.
> This can leave a non-responding TwillRunnable container running, and can lead
> to issues like two TwillRunnables with same instance id running at the same
> time.
> We should kill the containers that don't respond to stop message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
