[ 
https://issues.apache.org/jira/browse/TWILL-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439167#comment-15439167
 ] 

ASF GitHub Bot commented on TWILL-175:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/6#discussion_r76430188
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableProcessLauncher.java
 ---
    @@ -76,6 +76,11 @@ public String toString() {
     
         return new ProcessController<R>() {
           @Override
    +      public void close() throws Exception {
    +        // no-op
    --- End diff --
    
    No. Close should just release resources


> Hadoop21YarnAppClient caches a YarnClient
> -----------------------------------------
>
>                 Key: TWILL-175
>                 URL: https://issues.apache.org/jira/browse/TWILL-175
>             Project: Apache Twill
>          Issue Type: Bug
>    Affects Versions: 0.7.0-incubating
>            Reporter: Ali Anwar
>             Fix For: 0.8.0
>
>
> Hadoop21YarnAppClient caches a YarnClient.
> Internally, YarnClient is only useful for a single UserGroupInformation. 
> Because of this, you can not use the same Hadoop21YarnAppClient for multiple 
> UGIs.
> The Hadoop21YarnAppClient class should use a different YarnClient for each 
> UGI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to