Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/7#discussion_r76519593
  
    --- Diff: twill-core/src/main/java/org/apache/twill/internal/Configs.java 
---
    @@ -31,6 +31,11 @@
          */
         public static final String JAVA_RESERVED_MEMORY_MB = 
"twill.java.reserved.memory.mb";
     
    +    /**
    +     * Set this to false to disable the secure store updates done by 
default.
    +     */
    +    public static final String ENABLE_DEFAULT_SECURE_STORE_UPDATE = 
"twill.enable.default.secure.store.update";
    --- End diff --
    
    I think the common convention is to call it like 
`twill.secure.store.update.location.enabled` (from widest to narrowest scope, 
see hadoop-default.xml). Explicitly calling out `location` because that is what 
get updated by default right now and potentially there can be other secure 
store gets updated by default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to