Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/10#discussion_r78250998
--- Diff:
twill-discovery-core/src/main/java/org/apache/twill/discovery/DiscoverableAdapter.java
---
@@ -76,18 +78,9 @@ public Discoverable deserialize(JsonElement json, Type
typeOfT,
final String service = jsonObj.get("service").getAsString();
String hostname = jsonObj.get("hostname").getAsString();
int port = jsonObj.get("port").getAsInt();
+ final byte[] payload = context.deserialize(jsonObj.get("payload"),
BYTE_ARRAY_TYPE);
--- End diff --
No need to be final. Same for `service` above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
