[
https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478285#comment-15478285
]
ASF GitHub Bot commented on TWILL-107:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/10#discussion_r78250998
--- Diff:
twill-discovery-core/src/main/java/org/apache/twill/discovery/DiscoverableAdapter.java
---
@@ -76,18 +78,9 @@ public Discoverable deserialize(JsonElement json, Type
typeOfT,
final String service = jsonObj.get("service").getAsString();
String hostname = jsonObj.get("hostname").getAsString();
int port = jsonObj.get("port").getAsInt();
+ final byte[] payload = context.deserialize(jsonObj.get("payload"),
BYTE_ARRAY_TYPE);
--- End diff --
No need to be final. Same for `service` above.
> Support payloads for Discoverables
> ----------------------------------
>
> Key: TWILL-107
> URL: https://issues.apache.org/jira/browse/TWILL-107
> Project: Apache Twill
> Issue Type: Improvement
> Components: discovery
> Reporter: Parth Gandhi
>
> Discoverables store only a name and an InetSocketAddress. It would help
> extensibility to allow an arbitrary payload of bytes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
