Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82901178
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -298,6 +299,29 @@ public TwillPreparer addSecureStore(SecureStore
secureStore) {
public TwillPreparer setLogLevel(LogEntry.Level logLevel) {
Preconditions.checkNotNull(logLevel);
this.logLevel = logLevel;
+ Map<String, LogEntry.Level> logLevels = new HashMap<>();
+ logLevels.put(Logger.ROOT_LOGGER_NAME, logLevel);
+ saveLogLevels(Constants.SystemMessages.LOG_ALL_RUNNABLES, logLevels);
--- End diff --
Why use the `LOG_ALL_RUNNABLES` as a runnable name? We have the `twillSpec`
in this class, so it's easy to just expand the log level settings for each
runnable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
