Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83118218
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -132,16 +149,22 @@ void start(String runnableName, ContainerInfo
containerInfo, TwillContainerLaunc
try {
int instanceId = getStartInstanceId(runnableName);
RunId runId = getRunId(runnableName, instanceId);
+ Map<String, LogEntry.Level> logLevelsRunnable =
resourceReport.getLogLevels().containsKey(runnableName) ?
+ resourceReport.getLogLevels().get(runnableName) : new
HashMap<String, LogEntry.Level>();
+ logLevel = logLevelsRunnable.containsKey(Logger.ROOT_LOGGER_NAME) ?
--- End diff --
Is `ROOT_LOGGER_NAME` a special logger name? If that's the case, we should
be consistently using the map only. I see some other classes having both
`rootLogLevel` and the map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
