Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86273964
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,44 @@
* @return A {@link Future} that will be completed when the restart
operation has been done.
*/
Future<String> restartInstances(String runnable, int instanceId, int...
moreInstanceIds);
+
--- End diff --
It's not clear to me why these need to return a future (or anything at
all). Is it to be able to communicate an error/exception in case the setting of
the log level fails? So, when it returns it is guaranteed that all runnables
have actually adapted the new log level?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
