[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719101#comment-15719101
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r90768827
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
 ---
    @@ -51,29 +63,36 @@
       private final ClassLoader classLoader;
       private final BasicTwillContext context;
       private final ContainerLiveNodeData containerLiveNodeData;
    +  private final Map<String, LogEntry.Level> oldLogLevels;
    +  private final Map<String, LogEntry.Level> defaultLogLevels;
       private ExecutorService commandExecutor;
       private TwillRunnable runnable;
     
       public TwillContainerService(BasicTwillContext context, ContainerInfo 
containerInfo, ZKClient zkClient,
                                    RunId runId, TwillRunnableSpecification 
specification, ClassLoader classLoader,
    -                               Location applicationLocation) {
    +                               Location applicationLocation, Map<String, 
LogEntry.Level> defaultLogLevels,
    +                               Map<String, LogEntry.Level> logLevels) {
         super(zkClient, runId, applicationLocation);
     
         this.specification = specification;
         this.classLoader = classLoader;
    -    this.containerLiveNodeData = createLiveNodeData(containerInfo);
    +    this.defaultLogLevels = ImmutableMap.copyOf(defaultLogLevels);
    +    this.oldLogLevels = Collections.synchronizedMap(new 
HashMap<>(defaultLogLevels));
    --- End diff --
    
    I see. Seems ok. 


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)