[ 
https://issues.apache.org/jira/browse/TWILL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806591#comment-15806591
 ] 

ASF GitHub Bot commented on TWILL-63:
-------------------------------------

Github user albertshau commented on a diff in the pull request:

    https://github.com/apache/twill/pull/21#discussion_r95050605
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
    @@ -277,9 +281,16 @@ public TwillPreparer prepare(TwillApplication 
application) {
         Preconditions.checkState(serviceDelegate.isRunning(), "Service not 
start. Please call start() first.");
         final TwillSpecification twillSpec = application.configure();
         final String appName = twillSpec.getName();
    +    RunId runId = RunIds.generate();
    +    Location appLocation = locationFactory.create(String.format("/%s/%s", 
twillSpec.getName(), runId.getId()));
    +    LocationCache locationCache = this.locationCache;
    +    if (locationCache == null) {
    +      locationCache =  new NoCachingLocationCache(appLocation);
    --- End diff --
    
    nit: extra space


> Speed up application launch time
> --------------------------------
>
>                 Key: TWILL-63
>                 URL: https://issues.apache.org/jira/browse/TWILL-63
>             Project: Apache Twill
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 0.2.0-incubating
>            Reporter: Terence Yim
>            Assignee: Terence Yim
>             Fix For: 0.10.0
>
>
> Currently when launching an application, two new jars are always created 
> locally, one for AM (appMaster.jar) and one for Container (container.jar) and 
> copied to HDFS before submitting the application. The jar files could 
> potentially be big and if it doesn't changed, it should require copying to 
> HDFS again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to