GitHub user serranom opened a pull request:
https://github.com/apache/twill/pull/29
(TWILL-211) use ALLOCATE_ONE_INSTANCE_AT_A_TIME for retries to preventâ¦
⦠poll starvation.
These changes fix a lingering bug identified by the tests for TWILL-181.
When creating a runnable container request, we check for number of instances
equal to one. For such cases we always set the allocation request to use
`ALLOCATE_ONE_INSTANCE_AT_A_TIME`. When retries occur, each failed instance
results in a single provision request, each asking for one instance. But if
`ALLOCATE_ONE_INSTANCE_AT_A_TIME` is _not_ set, the `handleCompleted` code will
never consider the request satisfied since it is waiting for all instances to
have been started.
The check for `null` at line 469 is necessary because these new provision
requests do not have a placement policy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serranom/twill TWILL-211
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 999eb3c19427e7e95abb1a83d3e697febaa6741f
Author: martin <mar...@attivio.com>
Date: 2017-01-29T20:28:18Z
TWILL-211, use ALLOCATE_ONE_INSTANCE_AT_A_TIME for retries to prevent poll
starvation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
