[
https://issues.apache.org/jira/browse/TWILL-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864378#comment-15864378
]
ASF GitHub Bot commented on TWILL-218:
--------------------------------------
GitHub user serranom opened a pull request:
https://github.com/apache/twill/pull/32
(TWILL-218), add the OptionSpec class as an explicit dependency for the…
… appmaster
I added the jar to the respective poms and added OptionSpec to the
appmaster dependency calculation. The dependency shows up because of Kafka:
[INFO] | | \- org.apache.kafka:kafka_2.10:jar:0.8.0:compile
[INFO] | | +- org.scala-lang:scala-library:jar:2.10.1:compile
[INFO] | | +- net.sf.jopt-simple:jopt-simple:jar:3.2:compile
[INFO] | | +- org.scala-lang:scala-compiler:jar:2.10.1:compile
[INFO] | | | \- org.scala-lang:scala-reflect:jar:2.10.1:compile
[INFO] | | +- com.101tec:zkclient:jar:0.3:compile
[INFO] | | +- com.yammer.metrics:metrics-core:jar:2.2.0:compile
[INFO] | | \-
com.yammer.metrics:metrics-annotation:jar:2.2.0:compile
However the twill dependency mechanism does not detect the dependency. By
making it explicit, it will always end up in the `twill.jar`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serranom/twill twill-218
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 989fb9926ba1d2dffdc66d3866080e66c5eeea1a
Author: serranom <martin.serr...@gmail.com>
Date: 2017-02-13T20:34:30Z
TWILL-218, add the OptionSpec class as an explicit dependency for the
appmaster
----
> The implicit jopt-simple dependency should be made explicit
> -----------------------------------------------------------
>
> Key: TWILL-218
> URL: https://issues.apache.org/jira/browse/TWILL-218
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Martin Serrano
> Assignee: Martin Serrano
> Fix For: 0.10.0
>
>
> Kafka has a dependency on jopt-simple. It seems that some of the scala code
> is opaque to twill dependency resolution because this dependency is not
> found. In environments that do not ship with jopt-simple, this shows up as a
> class not found exception which prevents the kafka service from coming up
> completely.
> While it would be better to have dependency resolution that discovered this
> on its own, explicitly adding the dependency solves the problem with minimal
> changes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
