GitHub user chtyim opened a pull request:

    https://github.com/apache/twill/pull/34

    Feature/twill 186

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/twill feature/twill-186

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/twill/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit b64c90b618f065ca01a8c5d36df2535b1344564e
Author: Terence Yim <cht...@apache.org>
Date:   2017-02-28T05:22:32Z

    (TWILL-186) Code cleanup for ApplicationMasterService and related classes
    
    - Get rid of the inner loop in the doRun method
      - The inner loop can block the heartbeat thread for too long if there are 
a lot of runnable instances to stop
    - Remove unnecessary throwables.propagate
    - Remove unnecessary intermediate method
    - Better logging
    - Request multiple instances in the same request
    - Refactory/simiply placement policy related code
    - Expose container instanceId instead of parsing it from runId

commit fcfa5becd61ddc2513f29a2be700b3be166d4b0b
Author: Terence Yim <cht...@apache.org>
Date:   2017-02-28T22:43:37Z

    (TWILL-186) Guard against YARN returning mismatch container size case.
    
    - Also make sure we don't remove container request without adding it
    first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to