Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/38#discussion_r106763105
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -211,7 +218,6 @@ public YarnApplicationReport getReport() {
try {
return new
Hadoop20YarnApplicationReport(yarnClient.getApplicationReport(appId));
} catch (YarnRemoteException e) {
- LOG.error("Failed to get application report {}", appId, e);
--- End diff --
removing the logging here is good. However, the messages could add useful
context (here: the appId). If you wrap it into a RuntimeException, why not add
the message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
