[ https://issues.apache.org/jira/browse/TWILL-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930903#comment-15930903 ]
ASF GitHub Bot commented on TWILL-119: -------------------------------------- Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/38#discussion_r106763336 --- Diff: twill-yarn/src/main/hadoop23/org/apache/twill/internal/yarn/Hadoop23YarnAppClient.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.twill.internal.yarn; + +import com.google.common.base.Joiner; +import com.google.common.base.Throwables; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.security.Credentials; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; +import org.apache.hadoop.security.token.TokenIdentifier; +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.hadoop.yarn.api.records.ContainerLaunchContext; +import org.apache.hadoop.yarn.client.api.YarnClient; +import org.apache.hadoop.yarn.conf.HAUtil; +import org.apache.hadoop.yarn.conf.YarnConfiguration; +import org.apache.hadoop.yarn.util.ConverterUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.net.InetSocketAddress; +import java.util.ArrayList; +import java.util.List; + +/** + * <p> + * The service implementation of {@link YarnAppClient} for Apache Hadoop 2.1 and beyond. + * + * The {@link VersionDetectYarnAppClientFactory} class will decide to return instance of this class for + * Apache Hadoop 2.1 and beyond. --- End diff -- ditto > Updates to work on a secure cluster with HA ResourceManager > ----------------------------------------------------------- > > Key: TWILL-119 > URL: https://issues.apache.org/jira/browse/TWILL-119 > Project: Apache Twill > Issue Type: Improvement > Components: yarn > Reporter: Albert Shau > Assignee: Terence Yim > Fix For: 0.11.0 > > > I have not tried it yet, but it seems like we may need some extra work for > Twill to run on a secure cluster that uses HA ResourceManager. The YarnUtils > class gets the socket addr for the RM using YarnConfiguration.RM_ADDRESS, but > in HA mode the conf contains YarnConfiguration.RM_HA_IDS, with each id having > a corresponding hostname setting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)