GitHub user chtyim opened a pull request:

    https://github.com/apache/twill/pull/40

    (TWILL-122) Allow disabling log collection

    - Introduced a new configuration twill.log.collection.enabled for
      turning off log collection
    - Refactor YarnTwillController and related class hierarchy to not
      starting Kafka client when log collection is disabled
    - Added Kafka zk connection string information in AM live node data
    - Refactor KafkaAppender and ServiceMain configureLogger
      - Log to StatusManager instead of Logger to avoid recursive logging
      - Instead of resetting logback configuration, directly instantiate and
        add the Kafka log appender to the logging context.
    - Refactor ServiceMain, ApplicationMasterMain and TwillContainerMain to
      simplify ZK Connection string construction

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/twill feature/TWILL-122

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/twill/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 617280ee72b2e7fc7a3cc473d6dfe35576cf5e57
Author: Terence Yim <cht...@apache.org>
Date:   2017-03-20T21:42:46Z

    (TWILL-122) Allow disabling log collection
    
    - Introduced a new configuration twill.log.collection.enabled for
      turning off log collection
    - Refactor YarnTwillController and related class hierarchy to not
      starting Kafka client when log collection is disabled
    - Added Kafka zk connection string information in AM live node data
    - Refactor KafkaAppender and ServiceMain configureLogger
      - Log to StatusManager instead of Logger to avoid recursive logging
      - Instead of resetting logback configuration, directly instantiate and
        add the Kafka log appender to the logging context.
    - Refactor ServiceMain, ApplicationMasterMain and TwillContainerMain to
      simplify ZK Connection string construction

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to