Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/46#discussion_r108490923
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -159,19 +159,19 @@ public static ApplicationId createApplicationId(long
timestamp, int id) {
return ImmutableList.of();
}
- FileSystem fileSystem = getFileSystem(locationFactory, config);
-
- if (fileSystem == null) {
- LOG.warn("Unexpected: LocationFactory is not backed by
FileContextLocationFactory");
- return ImmutableList.of();
- }
+ try (FileSystem fileSystem = getFileSystem(locationFactory)) {
+ if (fileSystem == null) {
+ LOG.warn("Unexpected: LocationFactory is not backed by
FileContextLocationFactory");
--- End diff --
seems that this message should be logged inside getFileSystem()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
