[
https://issues.apache.org/jira/browse/TWILL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951484#comment-15951484
]
ASF GitHub Bot commented on TWILL-189:
--------------------------------------
Github user albertshau commented on a diff in the pull request:
https://github.com/apache/twill/pull/48#discussion_r109225715
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -265,6 +254,44 @@ public void cancel() {
}
@Override
+ public Cancellable setSecureStoreRenewer(SecureStoreRenewer renewer,
long initialDelay,
+ long delay, long retryDelay,
TimeUnit unit) {
+ synchronized (this) {
+ if (secureStoreScheduler != null) {
+ // Shutdown and block until the schedule is stopped
+ stopScheduler(secureStoreScheduler);
+
+ Futures.getUnchecked(secureStoreScheduler.submit(new Runnable() {
--- End diff --
what is this doing? isn't it shutdown by stopScheduler()?
> SecureStoreUpdater should support updating secure store as other users
> ----------------------------------------------------------------------
>
> Key: TWILL-189
> URL: https://issues.apache.org/jira/browse/TWILL-189
> Project: Apache Twill
> Issue Type: New Feature
> Components: api
> Affects Versions: 0.7.0-incubating
> Reporter: Ali Anwar
> Fix For: 0.11.0
>
>
> SecureStoreUpdater always creates secure stores for the current user and
> writes these as the current user.
> It should allow writing the secure store as a different user.
> For an example use case, see: https://github.com/caskdata/cdap/pull/6380
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
